How to proceed with GoFish #145
Replies: 8 comments 11 replies
-
|
Lutz -- Significant work has already been done on a number of these issues in your absence. When you renamed 'GoFish5' to 'GoFish' (which made a lot of sense), you did not understand how your changes would be reflected in Thor, nor did you choose to so investigate. Thus, two changes only relevant to Thor (the name of a Thor tool and a folder name in Thor) created a mess that is still not entirely corrected. I spent about 15-20 hours in early October trying to correct it. This was avoidable and unnecessary. The problem now is that there are still leftovers in Thor causing confusion for users. While 'GoFish5' no longer shows in 'Check For Updates' (as there is no longer an updater for it), it does appear in other places in Thor. The fix that we have already implemented works like this: When a user installs your next update to GoFish, Thor checks to see if the old folder Tools\Apps\GoFish5 exists. If it does, it asks the user if all references to GoFish5 should be removed. If so:
I believe that most users have not seen this as the change was implemented after your last update to GoFish on 11/11. GoFishClassic (actually GoFish 5.1.009) is available for those who had problems with the new GoFish or who chose not to upgrade to it. The intent is that it will remain frozen without any changes. Users have noted that they cannot use both GoFish and GoFishClassic in the same session. Any other topics you mentioned should be addressed in separate issues in the appropriate VFPX project. |
Beta Was this translation helpful? Give feedback.
-
|
This was not the question. Anyway
I try to get on track again, so accusations are not very helpful. I take my part of the responsibility, but please, let's discuss this somewhere else. Issues? This is a discussion. The result should be to see what need to be done. And this might or might not result in issues. Can we proceed step by step? This is now and here: Please list problems with the state of GoFish now (with or without Thor), not with persons or old commits. As simple as possible. |
Beta Was this translation helpful? Give feedback.
-
|
My sincere apologies for this. It really never occurred to me that anybody other than you were responsible for these changes. I am truly sorry that I offended you with this error. / Jim |
Beta Was this translation helpful? Give feedback.
-
|
I was addressing two of your issues, in particular the second one. All the other bullet points should be in separate issues.
|
Beta Was this translation helpful? Give feedback.
-
|
Again, this is not an issue. This is a discussion.
Just a way to figure out where and what all the last months where about and how to proceed. Discussions should not trigger actions. An issue might. |
Beta Was this translation helpful? Give feedback.
-
|
To address other points:
|
Beta Was this translation helpful? Give feedback.
-
In parallel
SourcesThe Thor files and the sources are very unlucky mingled. This should be done by better standard - in special since VFPXDeployment exists. |
Beta Was this translation helpful? Give feedback.
-
|
The replies are getting messy. I agree with @Jimrnelson: one discussion, one topic. Otherwise it's hard to follow what reply goes with what topic. In parallel:
SourceYes, I agree, but as I said, it is not a priority since it doesn't cause any harm. |
Beta Was this translation helpful? Give feedback.
-
|
@DougHennig, @Jimrnelson I'm puzzled too. Sure, you both are way to fast answering questions. That was not intended. I'm just in the gathering questions mode. The stuff on top are the questions / problems I saw, and I was waiting for your questions / problems / suggestions. Not your answers (yet) |
Beta Was this translation helpful? Give feedback.
-
|
Just back to my desk.
I'd be happy to start responding to these points if they were in separate
discussions.
…On Thu, Dec 7, 2023 at 10:05 AM Doug Hennig ***@***.***> wrote:
To address other points:
- GF5 runs not in parallel with GF6: I do not see that as a problem.
Use one or the other but not both. As @Jimrnelson
<https://github.com/Jimrnelson> noted, installing GF now prompts you
to remove GF 5.
- GF's auto hooking into Thor: I believe that was removed (or am I
misremembering, @Jimrnelson <https://github.com/Jimrnelson>?)
- Thor installation comes with sources: that could be cleaned up at
some point but since it does not cause a problem, it is not a priority
—
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATLLFR2CFILZ4ZRD2SFTILDYIHZNDAVCNFSM6AAAAABAK2N3SOVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TOOJRGMYDQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Jim Nelson
|
Beta Was this translation helpful? Give feedback.
-
|
@Jimrnelson IOW You have nothing to do or to suggest? |
Beta Was this translation helpful? Give feedback.
-
|
I have already responded that some of the items have already been addressed (and you had no way to know that had happened) And the other items (from the original message in this thread) would best be discussed in separate discussion threads. You had six different bullet points. They are not closely related. The discussions are best handled, in my opinion, separately. So, for starters, that is exactly what I suggest. |
Beta Was this translation helpful? Give feedback.
-
|
I'm really sorry, but some don't grok the idea of the discussion. I had a certain stand of information, liked to go on recent, possibly learn what was done (what is not as simple as you like to express, thanks for the arrogance) - or even if you liked me to participate at all, what is also within the possibilities, due to my behaviour. It was just a try to sort it out. To learn what was done and what not. For me this discussion makes no sense any more. One managed to spoil it unreadable to me with half answers and half accusations. For some it is simple to difficult to answer question by question. The whole discussion *was intended to have stuff related only that they belong to GoFish. To see, what is aside the issues page important to do in this mixture of half done work, added ancient versions. To talk about a way to proceed. If this so clear to some, go ahead. I do not see it, and I do learn nothing on this. |
Beta Was this translation helpful? Give feedback.
-
|
Lutz -- First of all, I want to state again that I was completely wrong to think you were any way involved in the renaming of GoFish5 to GoFish. While this did cause me a lot of unneeded work in Thor, it had nothing to do with you in any way. I am sorry for my message impugning you in any way. I was wrong, I ask for you to forgive this mistake. I also hope that we can get past this. There's a lot of work to be done. |
Beta Was this translation helpful? Give feedback.
-
|
Dear @Jimrnelson, Must be my age - I read this the other way. I beg your pardon. The problem is that I was preparing to do this - use GoFish instead of GoFish5. For obvious reasons. You pulled a trigger a trigger you possibly didn't notice. This is why I stopped in June. Starting from this I fixed some issues, but this things where in an odd state, and I was unable to proceed. Finally I pushed the changes to my fork, let others do the merging, and I guess something on this process caused the problems. The idea was just to alter the code, but possibly the change to the appname was merged too. From that all I noticed was havoc, and I decided not do anything on it, because the state was to odd, and the danger to create more havoc to high. So I started a discussion to figure out what I know, what is done, what need to be done. And how to proceed at all. See others POV. This was the whole idea on this discussion. Any way, this discussion is now so crowded, there is little hope to follow it. That's why I closed it. I try to find a different way to gather the information I need. We can try to start over, if you like. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, and there definitely was confusion about the use and understanding of the word "issues". I have been using it (in this thread) to refer to "things to talk about". That is, in a discussion, what are the things / topics / items/ issues to be discussed? (For me, those choices are interchangeable.) You clearly (and reasonably) understood my reference to it as meaning "Issues on the Issues Page". Let's start over. Each of the items in you original bullet list are worthy of discussion. I believe that there would be enough to discuss for each item to warrant separate discussions. I do understand that you want to get a handle of where we are on each item, but I believe (knowing us) there will be a lot to say about each. I would find having them intertwined in one Discussion to be quite confusing. |
Beta Was this translation helpful? Give feedback.
-
|
That's a start. :) And yes, we should not go into detail for stuff we identified worth further discussion here. This was so obvious to me, I forgot to mention. :( What remains, is the question for other stuff that should be addressed you or @DougHennig or anybody else know outside normal issues . |
Beta Was this translation helpful? Give feedback.
-
|
For now, we have a good starting list. If other items (not calling them issues!) for discussion come to mind, they can be added later. Right now, I see about 25 issues on the Issue page for Thor. Plenty to keep me busy. I have not looked at the Issues page for GF, but would imagine there might be quite a few there as well. |
Beta Was this translation helpful? Give feedback.
-
|
GF? 34 open as of now, not all valuable. The question that remains it, what must be done before we go to the regular issues page. |
Beta Was this translation helpful? Give feedback.
-
We need to discuss some points on how to proceed with GoFish.
I think we should start pointing out the big problems we have yet, not some UI problems or the like. After that we should discuss it, but for starters, just identify problems. The list below is just that what is in my mind right now.
For what I see right now
Beta Was this translation helpful? Give feedback.
All reactions