Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie-consent dialog display flicker #69

Open
michaelwood opened this issue Apr 14, 2022 · 1 comment
Open

cookie-consent dialog display flicker #69

michaelwood opened this issue Apr 14, 2022 · 1 comment

Comments

@michaelwood
Copy link
Member

michaelwood commented Apr 14, 2022

Overrides in 360-ds are coming back to bite us, the .base-card class has been implemented on cookie-consent dialog but this sets a display property which is interfering with the toggling of the cookie-consent display, causing it to pop up and disappear on page load if an option (yes/no/no analytics) has already been made.

Two options for solving this, add another override #68 which works but is fragile, or fix it more sustainably and rewrite the dialog without using the existing modules from the design system, creating a completely new standalone component.

In general we are finding that the components/modules in the design system aren't generic enough to be re-usable. So this is an approach we may need to shift to.

@mariongalley
Copy link

Discussed with @robredpath - looks like the override bit is already more or less done, so although I don't like to kick problems down the road I'd suggest we use that rather than rewrite the dialog now. Would be good to keep documented somewhere that that still needs doing and include it in iterative improvements some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants