Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with forge auto-remappings #60

Open
kyriediculous opened this issue Aug 2, 2023 · 0 comments
Open

Problem with forge auto-remappings #60

kyriediculous opened this issue Aug 2, 2023 · 0 comments

Comments

@kyriediculous
Copy link
Member

When installing this repository as a git submodule using foundry, there are issues with both open-zeppelin modules used in this repository.

when running forge remappings in the target repository where this is installed, the open-zeppelin dependencies remappings are missing the /contracts suffix

this repo

openzeppelin-contracts-upgradeable/=lib/openzeppelin-contracts-upgradeable/contracts/
openzeppelin-contracts/=lib/openzeppelin-contracts/contracts/

target repo

      openzeppelin-contracts-upgradeable/=/Users/nico/tenderize/tenderswap/lib/staking/lib/openzeppelin-contracts-upgradeable/contracts/
      openzeppelin-contracts/=/Users/nico/tenderize/tenderswap/lib/staking/lib/openzeppelin-contracts/
      ```

The current fix is to manually overwrite the incorrect automatic remappings in the target repo. 

openzeppelin-contracts-upgradeable/=lib/staking/lib/openzeppelin-contracts-upgradeable/contracts/
openzeppelin-contracts/=lib/staking/lib/openzeppelin-contracts/contracts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant