Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy navigation from GitHub PR URL #74

Open
lptr opened this issue Oct 29, 2024 · 5 comments
Open

Easy navigation from GitHub PR URL #74

lptr opened this issue Oct 29, 2024 · 5 comments
Labels
enhancement New feature or request github This issue is about our GitHub App

Comments

@lptr
Copy link

lptr commented Oct 29, 2024

Is your feature request related to a problem? Please describe.

I'd love to start using SemanticDiff, but most of the time I work with GitHub PRs. It would be great to have an easy way to navigate from a GitHub PR URL to the corresponding app.semanticdiff.com URL.

Describe the solution you'd like

A Chrome / Firefox extension perhaps that would add a button to switch over?

@lptr lptr added enhancement New feature or request github This issue is about our GitHub App labels Oct 29, 2024
@lptr
Copy link
Author

lptr commented Oct 29, 2024

Another option would be to add a search URL on app.semanticdiff.com that we could use with a GitHub URL. This way one could set up a "search engine" in their browser.

@mmueller2012
Copy link
Contributor

We just deployed an update that adds support for OpenSearch. It basically allows the browser to use the search functionality that was already available on app.semanticdiff.com. You can either enter a GitHub URL and be forwarded to the corresponding SemanticDiff page or search for pull requests. You need to be authenticated to use the search. If you are not authenticated yet, you will be forwarded to GitHub to login via OAuth.

To add the search provider, first go to any page on https://app.semanticdiff.com. Now the instructions differ a bit depending on the browser. In Firefox just focus the navigation bar and click on the SemanticDiff icon in the bottom row to add it as a search provider. In Chrome, you need to go to chrome://settings/searchEngines and scroll down to the list of inactive shortcuts. Look out for SemanticDiff and activate it. You may need to expand the list.

@lptr
Copy link
Author

lptr commented Nov 5, 2024

This is great, though I cannot yet get it to work in Chrome. I don't see anything related to SemanticDiff in the chrome://settings/searchEngines list. I tried expanding, reloading, nothing.

@mmueller2012
Copy link
Contributor

Did you check the last list "Inactive Shortcuts"? After expanding the list, I can find SemanticDiff:

image

@slackner Can you double check if it works for you?

@slackner
Copy link
Contributor

slackner commented Nov 5, 2024

It works fine for me with Google Chrome.

The exact steps are as follows:

  • I visited https://app.semanticdiff.com/ and logged in
  • Then I opened up chrome://settings/searchEngines
  • SemanticDiff appeared in the section Inactive shortcuts
  • I enabled it and changed the shortcut to @semanticdiff
  • Typing @semanticdiff and then some search term correctly opens up the search feature within SemanticDiff

@lptr Could you double check? If it doesn't work, which version of Chromium / Google Chrome are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github This issue is about our GitHub App
Projects
None yet
Development

No branches or pull requests

3 participants