Crash during startup garbage collector when spawned npc memory is mislinked

[mtwango]

When Sphere is starting, world and characters are loaded and Garbage Collector starts, if spawned NPC has memory item, that should be linked to spawn (or anything existing really) is mislinked (link ID doesn't exists), Sphere crashes without error and without any info in logs.

It used to work in rev 3720 it printed debug log and critical error (no id or anything usefull actually), but rev 3882 / 3888 crashes silently.

rev 3720 log:

Expected behaviour would be logging item id with wrong link and removing it during GC (and maybe remove container for this memory, if it is npc?)

[Jhobean]

Could be link to #1307

[mtwango]

I was able to track this error here:

Source-X/src/game/items/CItemMemory.cpp

Line 107 in 6a036d5

CCSpawn *pSpawn = static_cast<CCSpawn*>(m_uidLink.ItemFind()->GetComponent(COMP_SPAWN));

The m_uidLink.ItemFind() returns null pointer, which would be the reason for crash, since it can call GetComponent(COMP_SPAWN) on that.

Fixing it should be something like checking for valid return from ItemFind(). I'm not sure if code bellow is production ready, but I was able to pass GC.

CItem *pItemDef = m_uidLink.ItemFind();
if (pItemDef == nullptr)
{
    // return some error code here.
}

CCSpawn *pSpawn = static_cast<CCSpawn*>(pItemDef->GetComponent(COMP_SPAWN));

[Jhobean]

What about just add this
Does it fixe?

if (pItemDef == nullptr)
	return nullptr;

[mtwango]

It should return integer (int CItemMemory::FixWeirdness()). I was returning 0 to pass it.