Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for EntraID in OIDC #1023

Closed
3 tasks done
spyr0-sec opened this issue Dec 17, 2024 · 4 comments
Closed
3 tasks done

Feature: Add support for EntraID in OIDC #1023

spyr0-sec opened this issue Dec 17, 2024 · 4 comments
Labels
enhancement New feature or request ticketed (automation only) Ticket has been created internally for tracking

Comments

@spyr0-sec
Copy link
Contributor

Description:

The static OIDC configuration contains scopes which are not supported by EntraID and other identity providers

Are you intending to fix this bug?

No

Component(s) Affected:

  • UI
  • API

Steps to Reproduce:

  1. Settings
  2. Administration
  3. SSO Configuration
  4. Configure SSO Provider

Expected Behavior:

The identity provider is correctly configured for SSO

Actual Behavior:

The Oauth config includes scopes which are not supported and therefore returns error messages

Screenshots/Code Snippets/Sample Files:

https://github.com/SpecterOps/BloodHound/blob/v6.3.0/cmd/api/src/api/v2/auth/oidc.go#L109

Environment Information:

BloodHound: v6.3.0

Additional Information:

For our identity provider, only "openid", "profile", "email" are supported.

As per slack thread, EntraID is complaining about the email_verified scope

Potential Solution (optional):

Make the configuration more customisable with the ability to select which scopes are required for the given IdP

Related Issues:

N/A

Contributor Checklist:

  • I have searched the issue tracker to ensure this bug hasn't been reported before or is not already being addressed.
  • I have provided clear steps to reproduce the issue.
  • I have included relevant environment information details.
@spyr0-sec spyr0-sec added bug Something isn't working triage This issue requires triaging labels Dec 17, 2024
@StephenHinck
Copy link
Contributor

Thanks for the report, @spyr0-sec. We looked at this, and while that error message about supported scopes is accurate, additional effort is necessary to support EntraID for OIDC as their implementation requires additional functionality beyond the standards we wrote. We have some additional SSO functionality going into our next release (week of January 13th) and then we'll finish out the work necessary to get EntraID supported via OIDC.

@StephenHinck StephenHinck added enhancement New feature or request ticketed (automation only) Ticket has been created internally for tracking and removed bug Something isn't working triage This issue requires triaging labels Jan 2, 2025
@StephenHinck StephenHinck changed the title Bug: Unsupported OIDC Scopes Feature: Add support for EntraID in OIDC Jan 2, 2025
@StephenHinck
Copy link
Contributor

This is fixed with #1051. This will be included in next week's release!

@StephenHinck
Copy link
Contributor

Hey @spyr0-sec - unfortunately, more work is required. We fixed the issue with the scopes that Microsoft doesn't support; however, they still have additional hurdles outside of that, which we need to account for. We will try again and hope to get it into our next release on the week of February 3rd.

@spyr0-sec
Copy link
Contributor Author

@StephenHinck no problem! Thank you for the update and all the teams efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ticketed (automation only) Ticket has been created internally for tracking
Projects
None yet
Development

No branches or pull requests

2 participants