Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Handle all unhandled promises in the tests #466

Open
C0ZEN opened this issue May 23, 2020 · 7 comments
Open

[FEATURE] Handle all unhandled promises in the tests #466

C0ZEN opened this issue May 23, 2020 · 7 comments
Labels
bug Something isn't working feature-request Contains a feature/enhancement request help wanted Extra attention is needed
Milestone

Comments

@C0ZEN
Copy link
Member

C0ZEN commented May 23, 2020

Describe the bug
There are a bunch of unhandled promises in the tests.

Like:

UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch().
To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 13)

To Reproduce
Steps to reproduce the behavior:

  1. Run the tests

Expected behavior
No warning/errors.

@C0ZEN C0ZEN added the bug Something isn't working label May 23, 2020
@C0ZEN C0ZEN added this to the v2.0.0 milestone May 23, 2020
@C0ZEN
Copy link
Member Author

C0ZEN commented Jun 11, 2020

I really need help with that.
I can't find what is wrong...

@C0ZEN
Copy link
Member Author

C0ZEN commented Jul 10, 2020

See this Stackoverflow thread opened.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2020

⚠️ Warning! ⚠️

This issue was marked as stale due to a lack of activity for two months. 😟
In one month this issue will be closed if there is no more activity during this period. 😬

If you want to avoid this stale state you could add one of these labels:

  • label: waiting
  • label: wontfix
  • label: dependency-fix
  • label: opened-pull-request

@github-actions github-actions bot added the no-issue-activity Stale issue label Sep 9, 2020
@C0ZEN C0ZEN added help wanted Extra attention is needed and removed no-issue-activity Stale issue labels Sep 9, 2020
@C0ZEN C0ZEN changed the title Handle all unhandled promises in the tests [FEATURE] Handle all unhandled promises in the tests Sep 9, 2020
@C0ZEN C0ZEN added the feature-request Contains a feature/enhancement request label Sep 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

⚠️ Warning! ⚠️

This issue was marked as stale due to a lack of activity for two months. 😟
In one month this issue will be closed if there is no more activity during this period. 😬

If you want to avoid this stale state you could add one of these labels:

  • label: waiting
  • label: wontfix
  • label: dependency-fix
  • label: opened-pull-request
  • label: help wanted

@github-actions github-actions bot added the no-issue-activity Stale issue label Nov 9, 2020
@C0ZEN C0ZEN removed the no-issue-activity Stale issue label Nov 11, 2020
@github-actions
Copy link
Contributor

⚠️ Warning! ⚠️

This issue was marked as stale due to a lack of activity for two months. 😟
In one month this issue will be closed if there is no more activity during this period. 😬

If you want to avoid this stale state you could add one of these labels:

  • label: waiting
  • label: wontfix
  • label: dependency-fix
  • label: opened-pull-request
  • label: help wanted

@github-actions github-actions bot added the no-issue-activity Stale issue label Jan 11, 2021
@C0ZEN C0ZEN removed the no-issue-activity Stale issue label Jan 16, 2021
@github-actions
Copy link
Contributor

⚠️ Warning! ⚠️

This issue was marked as stale due to a lack of activity for two months. 😟
In one month this issue will be closed if there is no more activity during this period. 😬

If you want to avoid this stale state you could add one of these labels:

  • label: waiting
  • label: wontfix
  • label: dependency-fix
  • label: opened-pull-request
  • label: help wanted

@github-actions github-actions bot added the no-issue-activity Stale issue label Mar 18, 2021
@C0ZEN C0ZEN removed the no-issue-activity Stale issue label Mar 18, 2021
@github-actions
Copy link
Contributor

⚠️ Warning! ⚠️

This issue was marked as stale due to a lack of activity for two months. 😟
In one month this issue will be closed if there is no more activity during this period. 😬

If you want to avoid this stale state you could add one of these labels:

  • label: waiting
  • label: wontfix
  • label: dependency-fix
  • label: opened-pull-request
  • label: help wanted

@github-actions github-actions bot added the no-issue-activity Stale issue label May 18, 2021
@C0ZEN C0ZEN removed the no-issue-activity Stale issue label May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature-request Contains a feature/enhancement request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant