[Feat/#66] SearchResultItem 구현 #69
Open
+101
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chattymin
approved these changes
Jan 17, 2025
| .fillMaxWidth() | ||
| .border(1.dp, SpoonyAndroidTheme.colors.gray100) | ||
| .background(Color.White) | ||
| .noRippleClickable { onResultClick } |
There was a problem hiding this comment.
p4) 불필요한 람다를 생성하지 않고 바로 사용해주세요~
Suggested change
| .noRippleClickable { onResultClick } | |
| .noRippleClickable(onClick = onResultClick) |
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_delete_filled_24), | ||
| contentDescription = null, | ||
| tint = SpoonyAndroidTheme.colors.gray400, | ||
| modifier = Modifier.noRippleClickable { onDeleteClick } |
Hyobeen-Park
requested changes
Jan 17, 2025
Comment on lines
+63
to
+68
| Text( | ||
| text = placeName, | ||
| style = SpoonyAndroidTheme.typography.body2b, | ||
| color = SpoonyAndroidTheme.colors.black, | ||
| maxLines = 1 | ||
| ) |
There was a problem hiding this comment.
P2: 여기도 overflow 설정해주세요!!
Roel4990
requested changes
Jan 18, 2025
Comment on lines
+56
to
+60
| Icon( | ||
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_pin_24), | ||
| contentDescription = null, | ||
| modifier = Modifier.size(20.dp) | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
To Reviewers 📢
항상 좋은 리뷰 감사합니다 :)