[FEAT/#58] CustomDropDownMenu 구현 #68
Open
+199
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chattymin
approved these changes
Jan 17, 2025
| this.alpha = alpha | ||
| transformOrigin = TransformOrigin(0.5f, 0f) | ||
| } | ||
| .padding(horizontal = 20.dp) |
There was a problem hiding this comment.
p2) 외부의 패딩과 같아야 한다는 부분이 조금 걸리긴 하지만...
현재로서는 지금이 최선일 것 같네요.
그렇다면 외부의 패딩이 변경되어도 같은 값을 넣을 수 있도록 paddingValue를 매개변수로 받아오는건 어떨까요?
There was a problem hiding this comment.
오호 매개변수로 받아오는 것도 좋아보이는데요?!??
| isVisible = isDropdownVisible, | ||
| onDismissRequest = { isDropdownVisible = false }, | ||
| modifier = Modifier | ||
| .offset(y = (textFieldSize + 4).dp) |
There was a problem hiding this comment.
p4) 위에 있는 @SuppressLint("UseOfNonLambdaOffsetOverload")린트가 offset을 ()로 묶으면 생기는 오류라고 합니다.
람다로 변경이 가능하다면 변경부탁드려요 :)
Hyobeen-Park
approved these changes
Jan 17, 2025
| this.alpha = alpha | ||
| transformOrigin = TransformOrigin(0.5f, 0f) | ||
| } | ||
| .padding(horizontal = 20.dp) |
There was a problem hiding this comment.
오호 매개변수로 받아오는 것도 좋아보이는데요?!??
Comment on lines
+124
to
+129
| Text( | ||
| text = placeName, | ||
| style = SpoonyAndroidTheme.typography.body2b, | ||
| color = SpoonyAndroidTheme.colors.black, | ||
| maxLines = 1 | ||
| ) |
There was a problem hiding this comment.
P2: 혹시 여기에는 overflow 설정 안해줘도 괜찮나요???
Roel4990
approved these changes
Jan 18, 2025
| this.alpha = alpha | ||
| transformOrigin = TransformOrigin(0.5f, 0f) | ||
| } | ||
| .padding(horizontal = 20.dp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
2025-01-18.2.35.33.mov
To Reviewers 📢
모두들 감사합니다.