Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing additional arguments to SIPP. #75

Closed
afrolov-fuze opened this issue Oct 4, 2021 · 3 comments
Closed

Passing additional arguments to SIPP. #75

afrolov-fuze opened this issue Oct 4, 2021 · 3 comments

Comments

@afrolov-fuze
Copy link

Hi, thanks for the great software! I have one question though, could not find the answer in the docs or code:
How can I pass arguments that are not listed in pysipp.command.sipp_spec, like -min_rtp_port, to SIPP executable?

@goodboy
Copy link
Member

goodboy commented Oct 5, 2021

@afrolov-fuze good question 😂

I'm not sure we have a way to do that easily.

If you have ideas for how you'd like it exposed please do speak up.

@afrolov-fuze
Copy link
Author

I am not very familiar with pysipp code, but I would imagine adding parameter like additional_arguments to Agent constructor. This would be a list of string (for flags) or tuple of strings (for key-value arguments). CMD renderer should be modified in that case to incorporate additional arguments.

Meanwhile I found a dirty hack to inject additional arguments to SIPp command:
pysipp.client(..., media_port="6000' -cp '8888")

@iikercosta
Copy link

iikercosta commented Sep 23, 2022

@afrolov-fuze good question 😂

I'm not sure we have a way to do that easily.

If you have ideas for how you'd like it exposed please do speak up.

The way to support more arguments easily could be by modifying the sipp_spec list in the commands module and adding support for all the arguments in the current version of SIPp. As for example in this PR: #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants