New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERRASER script converting python versions results in spurious diffs #41

Open

everyday847 opened this issue Apr 30, 2016 · 1 comment

Member

everyday847 commented Apr 30, 2016

So, there's this pair of scripts in ERRASER: convert_to_phenix_python and convert_to_sys_python. There are two issues:

The sed syntax is platform dependent. I don't think sed -i 's/env python/env phenix.python/g' *.py works on Macs. (At least, it gives me sed: 1: "SWA_rebuild.py": invalid command code S and I do think there's a platform dependence, from what I remember.)
You cannot use these scripts in a checkout of the repo where you are doing any development work or you will commit spurious changes. The files it changes are versioned, after all.

The text was updated successfully, but these errors were encountered:

everyday847 assigned everyday847 and calebgeniesse and unassigned everyday847

Member Author

everyday847 commented Apr 30, 2016

sed -i -e seems to be cross platform, btw

roccomoretti unassigned calebgeniesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment