Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code stability #8

Open
Tracked by #12
dynafide opened this issue Sep 27, 2022 · 3 comments
Open
Tracked by #12

Improve code stability #8

dynafide opened this issue Sep 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dynafide
Copy link
Collaborator

In order to improve the stability of Resurgence as a library, all calls to panic!() .unwrap() and todo!() should be rewritten to pass results to the calling application. I'm creating this issue to keep track of progress.

@dynafide dynafide added the bug Something isn't working label Sep 27, 2022
@StandingPadAnimations
Copy link
Member

I think for .unwrap() we can use a try catch statement and handle the error internally

@StandingPadAnimations
Copy link
Member

todo!() statements will not be part of the first stable release unless something odd happens

@dynafide
Copy link
Collaborator Author

.expect(err) should also be avoided before stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants