Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document basic commissioning procedure #1274

Open
martukas opened this issue Jul 4, 2022 · 2 comments
Open

Document basic commissioning procedure #1274

martukas opened this issue Jul 4, 2022 · 2 comments
Labels
Documentation Improvements or additions to documentation Software Umbrella: GUI, Controller or CI Systems Requests for clarification on requirements? Requests for assistance? Tag them here.

Comments

@martukas
Copy link
Member

martukas commented Jul 4, 2022

What is required
Start documentation on how a newly build ventilator unit should be commissioned. Once the software has been deployed, what steps need to be taken for initial configuration. My current guess is:

  • set and confirm serial number
  • manually set any constants for installed components, e.g. valve or venturi coefficients determined by physical configuration
  • perform any automatic calibration procedures
  • register unit with online database and give it an authentication token - for test data submission and error reporting
  • ???

How do you know it has to be done
We already have units with different PSOLs, for example. We will not be building hacked or ifdeffed code to configure them as this would be a maintenance nightmare.

Starting points
Serial number is already configurable via debug interface. Once at least #1273 is done, it should be possible to write a procedure for PSOL configuration. With other related calibration tickets - same for even more components. As progress is made on https://github.com/RespiraWorks/test-data-browser , an authentication token should also become available.

@martukas martukas added Documentation Improvements or additions to documentation Systems Requests for clarification on requirements? Requests for assistance? Tag them here. Software Umbrella: GUI, Controller or CI labels Jul 4, 2022
@martukas
Copy link
Member Author

martukas commented Jul 4, 2022

PSOL constants that have been recently hard-coded:

// UFlow IBV19M values
static constexpr float PSolClosed{0.35f};
static constexpr float PSolOpen{0.75f};

// SMC PVQ31-40 values
static constexpr float PSolClosed{0.35f};
static constexpr float PSolOpen{0.95f};

But ideally should be experimentally tuned using calibration scripts.

@martukas
Copy link
Member Author

martukas commented Jul 8, 2022

Related ticket and comments in #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Software Umbrella: GUI, Controller or CI Systems Requests for clarification on requirements? Requests for assistance? Tag them here.
Projects
None yet
Development

No branches or pull requests

1 participant