Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt samples API to allow for filesystem less upload #32

Closed
danielwinkler opened this issue Jan 8, 2024 · 2 comments · Fixed by #40 or #41
Closed

Adapt samples API to allow for filesystem less upload #32

danielwinkler opened this issue Jan 8, 2024 · 2 comments · Fixed by #40 or #41
Assignees
@danielwinkler
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@danielwinkler
Copy link

Feature Request

Is your feature request related to a problem? Please describe.

This is related to the PR and discussion from #25

If I want to add a sample to the voice, I have to write it to the filesystem first (see EditVoiceAsync).
It would be great if we could pass in a ReadOnlyMemory<byte> like we get out the ClipData.

Some preliminary work was already in the above mentioned PR.

Cheers, daniel
@danielwinkler danielwinkler added the enhancement New feature or request label Jan 8, 2024
@StephenHodgson
Copy link
Member

Sounds good, open to PR.

Please make it an overload, don't replace existing method.

@StephenHodgson StephenHodgson added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 9, 2024
@RealStillkill
Copy link
Contributor

Submitted pull request #40

@StephenHodgson StephenHodgson linked a pull request Apr 5, 2024 that will close this issue
Add overloads to VoicesEndpoint that don't require use of the filesystem #40
Merged
@StephenHodgson StephenHodgson linked a pull request May 6, 2024 that will close this issue
ElevenLabs-DotNet 2.2.0 #41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielwinkler danielwinkler

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@danielwinkler @StephenHodgson @RealStillkill