Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F-Req] Pls Bring back Zink renderer #4219

Closed
GADTMOFFICIAL opened this issue May 21, 2023 · 9 comments
Closed

[F-Req] Pls Bring back Zink renderer #4219

GADTMOFFICIAL opened this issue May 21, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@GADTMOFFICIAL
Copy link

Is this request related to a bug?

No response

Describe the request.

Pls Bring back the Zink renderer in the older versions it was much better rendering Java shaders with less lag.

Hope you guys add it in the next update.

Anything else?

No response

@GADTMOFFICIAL GADTMOFFICIAL added the enhancement New feature or request label May 21, 2023
@GADTMOFFICIAL GADTMOFFICIAL changed the title [F-Req] <Short description> Pls Bring back Zink renderer [F-Req] Pls Bring back Zink renderer May 21, 2023
@jtghph
Copy link
Contributor

jtghph commented May 21, 2023

no

@aaaapai
Copy link

aaaapai commented May 21, 2023

Good idea, but they know they can render more light and shadow, so it's impossible to add back.

@jtghph
Copy link
Contributor

jtghph commented May 22, 2023

Good idea, but they know they can render more light and shadow, so it's impossible to add back.

@aaaapai We didn't say it's impossible. In fact we could add it back now.

The reason why it was removed in the first place is because of its performance. Yes, it can make shaders work, but at the cost of a terrible performance.

Zink runs on Vulkan, which in the first place Vulkan should be more powerful than GLES.

@root-S7
Copy link

root-S7 commented May 22, 2023

Minecraft does not support vulkan,it is used by Vulkan to OpenGL. It performance is not as good as "Holy GL4es".
Zink removes reason is compatibility issue.
Don't worry about light shader on your phone, OpenGL ES is too difficult

@rhjdvsgsgks
Copy link
Contributor

The reason why it was removed in the first place is because of its performance. Yes, it can make shaders work, but at the cost of a terrible performance.

it not only make shader works. but also provide higher opengl version. which means optimization mod like sodium will also able to work. with that, the performance of it is not too worse.

in fact. this is the test result on my device (a old low end qcom phone)

fps w/o sodium w/ sodium
gl4es 5 version string: 150version string: 150 coreERROR: 0:30: 'switch' : Reserved word. ERROR: 0:30: 'switch' : Syntax error: syntax error INTERNAL ERROR: no main() function!
angel 4 Enum 0x8501 is currently not supported
virgl 10 23

unlike the "fast/mid/slow" label in the setting. virgl is the fastest on my device. and, i tried comparing virgl/zink in termux. the latter have 1.5x fps than former. so i think its still necessary to keep zink. even it may perform slow on some device

@jtghph
Copy link
Contributor

jtghph commented May 30, 2023

it not only make shader works. but also provide higher opengl version. which means optimization mod like sodium will also able to work. with that, the performance of it is "not too worse".

2022-07-25_00 55 44
Yeah?

Mod or not, the problem itself is in the renderer, not the way how PojavLauncher uses it. I was able to get a decent (drumroll) 8fps because ¹i was playing on an old version, ²didn't fullscreen it.

Modern, bulkier phones wouldn't say the same thing otherwise; but if you use Zink on later versions, that's where the problem occurs. Nothing can fix this but to fix the renderer itself.

@rhjdvsgsgks
Copy link
Contributor

Modern, bulkier phones wouldn't say the same thing otherwise; but if you use Zink on later versions, that's where the problem occurs. Nothing can fix this but to fix the renderer itself.

what problem will occur (crash log)? please let me (or us) know. so that no one will keep asking zink in issus anymore. or even maybe some one can find a way to fix it

@rhjdvsgsgks
Copy link
Contributor

related #4242 #4246

@GaucovyAero
Copy link
Collaborator

added in the zink branch on github actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants