From 1ab92edb07170a2ef6eadec31331e8a6892f83a5 Mon Sep 17 00:00:00 2001
From: Kaloyan Gangov <gangov1@gmail.com>
Date: Wed, 24 Jul 2024 22:19:49 +0300
Subject: [PATCH] wip

---
 contracts/pool_stable/src/contract.rs   | 10 ++---
 contracts/pool_stable/src/math.rs       |  7 ----
 contracts/pool_stable/src/tests/swap.rs | 53 +++++++++++++------------
 3 files changed, 32 insertions(+), 38 deletions(-)

diff --git a/contracts/pool_stable/src/contract.rs b/contracts/pool_stable/src/contract.rs
index 530e5b428..8197aef3d 100644
--- a/contracts/pool_stable/src/contract.rs
+++ b/contracts/pool_stable/src/contract.rs
@@ -948,7 +948,7 @@ pub fn compute_swap(
         env,
         amp as u128,
         scale_value(
-            offer_pool + offer_amount,
+            offer_pool + convert_i128_to_u128(before_commission),
             greatest_precision,
             DECIMAL_PRECISION,
         ),
@@ -956,14 +956,13 @@ pub fn compute_swap(
             scale_value(offer_pool, offer_pool_precision, DECIMAL_PRECISION),
             scale_value(ask_pool, ask_pool_precision, DECIMAL_PRECISION),
         ],
-        ask_pool_precision,
+        greatest_precision,
     );
-    soroban_sdk::testutils::arbitrary::std::dbg!("DBG");
 
-    soroban_sdk::testutils::arbitrary::std::dbg!("DBG", ask_pool, new_ask_pool);
+    soroban_sdk::testutils::arbitrary::std::dbg!("SWAP", ask_pool, new_ask_pool);
+
     let return_amount = ask_pool - new_ask_pool;
     // We consider swap rate 1:1 in stable swap thus any difference is considered as spread.
-    soroban_sdk::testutils::arbitrary::std::dbg!("ALL GOOD");
     let spread_amount = if offer_amount > return_amount {
         convert_u128_to_i128(offer_amount - return_amount)
     } else {
@@ -1016,6 +1015,7 @@ pub fn compute_offer_amount(
         ],
         greatest_precision,
     );
+    soroban_sdk::testutils::arbitrary::std::dbg!("REVERSE SWAP", new_offer_pool, offer_pool);
 
     let offer_amount = new_offer_pool - offer_pool;
 
diff --git a/contracts/pool_stable/src/math.rs b/contracts/pool_stable/src/math.rs
index bf1f53d8f..d0badbaa7 100644
--- a/contracts/pool_stable/src/math.rs
+++ b/contracts/pool_stable/src/math.rs
@@ -21,12 +21,6 @@ const DECIMAL_FRACTIONAL: u128 = 1_000_000_000_000_000_000;
 const TOL: u128 = 1000000000000;
 
 pub fn scale_value(atomics: u128, decimal_places: u32, target_decimal_places: u32) -> u128 {
-    soroban_sdk::testutils::arbitrary::std::dbg!(
-        atomics,
-        decimal_places,
-        target_decimal_places,
-        decimal_places < target_decimal_places
-    );
     const TEN: u128 = 10;
 
     if decimal_places < target_decimal_places {
@@ -157,7 +151,6 @@ pub(crate) fn calc_y(
     xp: &[u128],
     target_precision: u32,
 ) -> u128 {
-    soroban_sdk::testutils::arbitrary::std::dbg!(amp, new_amount, xp, target_precision);
     let n_coins = U256::from_u128(env, N_COINS);
     let new_amount = U256::from_u128(env, new_amount);
 
diff --git a/contracts/pool_stable/src/tests/swap.rs b/contracts/pool_stable/src/tests/swap.rs
index 8e159ae8a..0e2f814d4 100644
--- a/contracts/pool_stable/src/tests/swap.rs
+++ b/contracts/pool_stable/src/tests/swap.rs
@@ -500,7 +500,7 @@ fn simple_swap_with_two_tokens_both_with_7_decimals() {
 
     token1.initialize(
         &admin,
-        &7,
+        &12,
         &"name1".into_val(&env),
         &"symbol1".into_val(&env),
     );
@@ -512,7 +512,7 @@ fn simple_swap_with_two_tokens_both_with_7_decimals() {
 
     token2.initialize(
         &admin,
-        &7,
+        &12,
         &"name2".into_val(&env),
         &"symbol2".into_val(&env),
     );
@@ -540,6 +540,7 @@ fn simple_swap_with_two_tokens_both_with_7_decimals() {
     pool.provide_liquidity(&user, &1_000, &1_000, &None, &None::<u64>);
 
     let spread = 100i64; // 1% maximum spread allowed
+    pool.simulate_reverse_swap(&token1.address, &1);
     pool.swap(
         &user,
         &token1.address,
@@ -548,30 +549,30 @@ fn simple_swap_with_two_tokens_both_with_7_decimals() {
         &Some(spread),
         &None::<u64>,
     );
-
-    let share_token_address = pool.query_share_token_address();
-    let result = pool.query_pool_info();
-
-    assert_eq!(
-        result,
-        PoolResponse {
-            asset_a: Asset {
-                address: token1.address.clone(),
-                amount: 1_001i128,
-            },
-            asset_b: Asset {
-                address: token2.address.clone(),
-                amount: 999i128,
-            },
-            asset_lp_share: Asset {
-                address: share_token_address.clone(),
-                amount: 1_000i128,
-            },
-            stake_address: pool.query_stake_contract_address(),
-        }
-    );
-    assert_eq!(token1.balance(&user), 99);
-    assert_eq!(token2.balance(&user), 101);
+    //
+    // let share_token_address = pool.query_share_token_address();
+    // let result = pool.query_pool_info();
+    //
+    // assert_eq!(
+    //     result,
+    //     PoolResponse {
+    //         asset_a: Asset {
+    //             address: token1.address.clone(),
+    //             amount: 1_001i128,
+    //         },
+    //         asset_b: Asset {
+    //             address: token2.address.clone(),
+    //             amount: 999i128,
+    //         },
+    //         asset_lp_share: Asset {
+    //             address: share_token_address.clone(),
+    //             amount: 1_000i128,
+    //         },
+    //         stake_address: pool.query_stake_contract_address(),
+    //     }
+    // );
+    // assert_eq!(token1.balance(&user), 99);
+    // assert_eq!(token2.balance(&user), 101);
 }
 
 #[test]