Hardcoded Values for BankTransfer and CashOnDelivery

[addison74]

ORIGINAL POST FROM HERE #1586

If you accept payments like BankTransfer or CashOnDelivery you have to validate them in Backend. The only problem is they are hardcoded and you have to edit core files by copying them in local folder. With the modifications bellow you can achieve this in Backend -> Sales -> Orders -> Invoices:

file: /app/code/core/Mage/Payment/Model/Method/Banktransfer.php
line: 47

 /*
  * Payment Method features
  * @var bool
  */
 // protected $_isGateway                   = false;
 // protected $_canOrder                    = false;
 // protected $_canAuthorize                = false;
 protected $_canCapture                  = true;
 //protected $_canCapturePartial           = false;
 //protected $_canCaptureOnce              = false;
 //protected $_canRefund                   = false;
 //protected $_canRefundInvoicePartial     = false;
 protected $_canVoid                     = true;
 //protected $_canUseInternal              = true;
 //protected $_canUseCheckout              = true;
 //protected $_canUseForMultishipping      = true;
 //protected $_isInitializeNeeded          = false;
 //protected $_canFetchTransactionInfo     = false;
 //protected $_canReviewPayment            = false;
 //protected $_canCreateBillingAgreement   = false;
 //protected $_canManageRecurringProfiles  = true;

 /*
  * Get instructions text from config

file: /app/code/core/Mage/Payment/Model/Method/Cashondelivery.php
line: 38

  /*
   * Payment Method features
   * @var bool
   */
  // protected $_isGateway                   = false;
  // protected $_canOrder                    = false;
  // protected $_canAuthorize                = false;
  protected $_canCapture                  = true;
  //protected $_canCapturePartial           = false;
  //protected $_canCaptureOnce              = false;
  //protected $_canRefund                   = false;
  //protected $_canRefundInvoicePartial     = false;
  protected $_canVoid                     = true;
  //protected $_canUseInternal              = true;
  //protected $_canUseCheckout              = true;
  //protected $_canUseForMultishipping      = true;
  //protected $_isInitializeNeeded          = false;
  //protected $_canFetchTransactionInfo     = false;
  //protected $_canReviewPayment            = false;
  //protected $_canCreateBillingAgreement   = false;
  //protected $_canManageRecurringProfiles  = true;

  /*
   * Cash On Delivery payment block paths

My personal opinion we should make a change in OpenMage code to control these values in Backend by a dropdown lists.