Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auth #2

Open
ayroblu opened this issue Dec 13, 2016 · 4 comments
Open

Add Auth #2

ayroblu opened this issue Dec 13, 2016 · 4 comments

Comments

@ayroblu
Copy link
Member

ayroblu commented Dec 13, 2016

You guys were talking about auth, just an fyi, I think I already included a basic version in the api (api/routes/auth) with some of the endpoints already defined, its missing things like password resets and stuff but the basics are there, including a bcrypt password hasher

@WesleyYep
Copy link
Contributor

WesleyYep commented Dec 14, 2016

Did this get brought up in today's meeting? I'm more comfortable using something like facebook login - there's a javascript sdk for it.
Then all we would need to do would be to store a list of trusted user and admin emails - no need to worry about passwords/resets/hashing/etc
This also assumes login functionality would only be needed through the website/app - and not the parking meter.

  • I'll post on the google group in case the managers have an opinion

@ayroblu
Copy link
Member Author

ayroblu commented Dec 14, 2016

Using the facebook sdk requires creating a facebook app, getting secret keys etc (something I haven't really worked out for an open source project)
Password hashing is literally a one liner, and again, I've already implemented half of it, its pretty straight forward. Its probably more standard to have both?

@eddiecjc
Copy link
Contributor

eddiecjc commented Dec 14, 2016 via email

@WesleyYep
Copy link
Contributor

Yeah I also prefer not to deal with passwords and registration ourselves. Although I see your point Ben, in that it wouldn't be too hard to add.
Maybe both could work, then at least we give the user a choice.
For admin/moderators - the facebook sdk contains a signedRequest field in the response, that provides info about the person calling the login api. I'm assuming it's fairly secure. Hence we could just store a mapping between this identification and their role (admin/mod/normal user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants