Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Navigation in Climb Search for image tagging context misbehaves #1191

Open
CocoisBuggy opened this issue Oct 30, 2024 · 8 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@CocoisBuggy
Copy link
Contributor

Steps to Reproduce

  1. Click 'New tag'
  2. Search for a climb
  3. Use keyboard nav works fine but when pressing "enter" the user is jumped to that route rather than having the item selected for tagging.

Screenshots

Expected Behavior

I think when the user is searching for a climb to tag, they likely want that item selected as the target rather than navigating to it

Current Behavior

The user is taken to the entry

Browser & version

<--- Example: Firefox 102.7.0esr -->

Operating system

<--- Example: MacOS 13.2.1 -->

@musoke
Copy link
Contributor

musoke commented Oct 30, 2024

This also happens in Android Firefox 131.0.3

@musoke musoke added the bug Something isn't working label Oct 30, 2024
@ShravaniRoy
Copy link
Contributor

Hey, I would like to work on this issue.

@CocoisBuggy
Copy link
Contributor Author

Yay! It's been bugging me @ShravaniRoy I will assign it to you.

@ShravaniRoy
Copy link
Contributor

I need help getting the API keys, as this issue requires a user login. I have sent an email.

@CocoisBuggy
Copy link
Contributor Author

Hey @ShravaniRoy glad you're getting along with the issue! I have no doubt viet will shoot you some keys shortly, but are you sure a typesense key is needed? I may need to refresh my memory but I thought the search feature worked in the standard dev environment? 🤔 if not, that probably needs to be an extra issue

@vnugent
Copy link
Contributor

vnugent commented Dec 8, 2024

@ShravaniRoy can you share the errors you're seeing? You shouldn't be required additional keys to open the search box.

@ShravaniRoy
Copy link
Contributor

I am able to open the search box. However, I am currently trying to reproduce the issue on my local machine.

I am redirected to the login page, when I try to upload an image, as I couldn't add a new tag for existing images.
Need help with this.

@ShravaniRoy
Copy link
Contributor

ShravaniRoy commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants