Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle error show/hide buttons #77

Merged
2 commits merged into from
Jan 3, 2023
Merged

Restyle error show/hide buttons #77

2 commits merged into from
Jan 3, 2023

Conversation

codemacabre
Copy link
Collaborator

Summary

  • Refactor and restyle the 'Show/Hide Errors' buttons
  • Ensure screenreaders announce buttons more accessibly (i.e. "Show [error type] errors")

Fixes: #65

Verify

  1. Upload JSON which contains errors
  2. Once processed, scroll to the 'Structure and Format' panel. Each error type should have:
    • Number of errors beside error type
    • A button with a chevron-down icon
  3. Activating the down-chevron button should:
    • Expand the error table
    • Change the chevron-down icon to a chevron-up icon

A 0.5s delay prevents rapidly expanding and collapsing the table, to prevent UI problems.

@codemacabre codemacabre requested review from duncandewhurst and a user December 23, 2022 12:58
@codemacabre codemacabre self-assigned this Dec 23, 2022
@codemacabre codemacabre mentioned this pull request Dec 23, 2022
Open
@ghost ghost merged commit 6b66353 into live Jan 3, 2023
@ghost
Copy link

ghost commented Jan 3, 2023

Thanks!

JS in cove_ofds/templates/cove_ofds/jsonschema_validation_panel.html - would be interesting to have a chat later about where is a good place for JS to live. Feels like several things to balance - page performance, maintainability ... No idea what right answer is!

@ghost ghost deleted the show-hide-buttons branch January 3, 2023 10:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncandewhurst duncandewhurst Awaiting requested review from duncandewhurst

Assignees

@codemacabre codemacabre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sections: Show hide buttons
1 participant
@codemacabre