-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC22 Credential Aging review #239
Comments
Agreed. But being prepared for key rotation, on the other side, is an important requirement IMHO. |
What is the policy for changing an SID? Should this get a new SID or can this just be rewritten? Further I would suggest to extract the Here a first draft to change AC22: Credential disclosureIf credentials (passwords and certificates) have a long lifetime their disclosure can have severe consequences, if the credentials cannot quickly be revoked and/or rotated. MitigationsAll credentials need a possibility to be revoked immediately and the credentials have to have high enough entropy and length to be future proof. References
|
@izar should I write a PR? |
sure thing! |
As mentioned in OWASP#239 AC22 Credential Aging review the threat AC22 Credential Aging was not helpful. This commit replaces AC22 with two new threats AC23 Credential Disclosure and AC24 Hardcoded Credentials. AC23 checks if the lifetime of the credentials is LONG, MANAUL, or UNKNOWN. Currently there is no way to resolve this threat by changing the model, besides setting the a different lifetime. AC24 warns against the use of hardcoded credentials.
As mentioned in OWASP#239 AC22 Credential Aging review the threat AC22 Credential Aging was not helpful. This commit replaces AC22 with two new threats AC23 Credential Disclosure and AC24 Hardcoded Credentials. AC23 checks if the lifetime of the credentials is LONG, MANAUL, or UNKNOWN. Currently there is no way to resolve this threat by changing the model, besides setting the a different lifetime. AC24 warns against the use of hardcoded credentials.
@noloader could you also look over my PR and give your opinion? |
Hi Everyone,
Threatlib has an item for AC22 Credential Aging:
We have learned that continuity is a better security property than rotation. Unexpected changes, like gratuitously changing public keys changing, is bad for security because it breaks pinning controls. And requiring users to rotate their password results in users choosing weaker and weaker passwords over time just to comply with a policy based on reading tea leaves.
The details and mitigation detailed in threatlib are completely wrong nowadays. They run counter to what we have learned from real world incidents and security usability studies. Nowadays we want public keys and passwords written in stone, and only changed if there is suspicion or proof of breach or misuse.
I think AC22 should be either removed from the model or limited in scope.
The text was updated successfully, but these errors were encountered: