Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capgen's Fortran parser does not allow array bounds which are not Fortran identifiers #588

Open
climbfuji opened this issue Sep 16, 2024 · 1 comment
Assignees
Labels

Comments

@climbfuji
Copy link
Collaborator

Description

capgen cannot parse array declarations that use an explicit lower bound, for example as in this line with the lower bound being an argument to the scheme:
https://github.com/ufs-community/ccpp-physics/blob/44700d5e92f00524ade276062e1f7c50e554c0fb/physics/SFC_Models/Lake/CLM/clm_lake.f90#L364

Steps to Reproduce

MISSING @dustinswales will create a test for this so that it can be reproduced and fixed easily

Please provide detailed steps for reproducing the issue.

  1. step 1
  2. step 2
  3. see the bug...

Additional Context

This is a valid Fortran expression that capgen needs to be able to process

Output

MISSING

@gold2718
Copy link
Collaborator

I am changing the title because I believe the problem is not the lower bound -- that seems to be okay.
The issue is that the parser does not know how to handle any array bound which is not a simple Fortran identifier.
There has been a doctest demonstrating this from the beginning.

Now to work on removing that restriction . . .

@gold2718 gold2718 changed the title capgen's Fortran parser does not understand array declarations that have lower bounds specified capgen's Fortran parser does not allow array bounds which are not Fortran identifiers Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

3 participants