Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Play Core Library for Android 14 Compatibility #175

Open
HarshitMadhav opened this issue Jun 21, 2024 · 15 comments
Open

Update Play Core Library for Android 14 Compatibility #175

HarshitMadhav opened this issue Jun 21, 2024 · 15 comments

Comments

@HarshitMadhav
Copy link

HarshitMadhav commented Jun 21, 2024

Firstly, thank you for this package @MinaSamir11 and the maintainers!

Issue Description:
There is an important compatibility issue with the current version of the Play Core library (com.google.android.play:core) and the upcoming Android 14 (targetSdkVersion 34).

Problem:
Google has introduced a backwards-incompatible change to broadcast receivers in Android 14 to improve user security. As a result, the current version of the Play Core library (core:1.9.0) is incompatible with targetSdkVersion 34. This incompatibility will cause crashes and other issues in apps targeting Android 14.

Impact:
Target SDK Requirement: From August 31, Google Play requires all new app releases to target Android 14.
Release Block: Apps using the current version of the Play Core library will not be able to release future versions to production or open testing.
User Security: The security improvements in Android 14 are crucial for user protection, and maintaining compatibility is essential.

Required Action:
Please update the Play Core Maven dependency to an Android 14 compatible version. This will ensure that applications using this library can continue to be released on the Google Play Store without any issues.

Reference:
Play Core Migration Guide

@HarshitMadhav
Copy link
Author

HarshitMadhav commented Jun 21, 2024

I have raised a Pull Request for this fix here
#176

@Durkaen
Copy link

Durkaen commented Jun 21, 2024

same here

Screenshot 2024-06-21 at 11 41 12

@HarshitMadhav
Copy link
Author

@Durkaen you can use the fix as I have added in the PR

@MinaSamir11
Copy link
Owner

MinaSamir11 commented Jun 22, 2024

I will checkout your pull request.

@MinaSamir11
Copy link
Owner

@Durkaen It seems that you are using the previous version, please checkout and mention your installed in-app-review version & update it to the latest version.

Thanks

@HarshitMadhav
Copy link
Author

@MinaSamir11 I am running on 4.3.3v

@manualexSP
Copy link

Hey guys, I'm having the same issues as well, any news? I noticed that the PR created for this issue was closed.

@MinaSamir11
Copy link
Owner

Hey guys, I'm having the same issues as well, any news? I noticed that the PR created for this issue was closed.

Already fixed in the latest version 4.3.3 &
please checkout if you're using another lib already using play core.

@manualexSP
Copy link

Yeah, it's all good :D Google mentioned a list of versions and I didn't notice that the current version is not on that list 😭

@talharasool
Copy link

talharasool commented Jun 28, 2024

@HarshitMadhav @MinaSamir11 Hey guys I am on the latest version but still facing issue in android. In the console it shows that it's working but the popup didn’t appear in debug mode and internal testing any solution for it?

@MinaSamir11
Copy link
Owner

@HarshitMadhav @MinaSamir11 Hey guys I am on the latest version but still facing issue in android. In the console it shows that it's working but the popup didn’t appear in debug mode and internal testing any solution for it?

Please read well the readme file, to solve your issue.

@Durkaen
Copy link

Durkaen commented Jul 9, 2024

@Durkaen It seems that you are using the previous version, please checkout and mention your installed in-app-review version & update it to the latest version.

Thanks

Oh my bad, sorry. I've upgraded to the latest version now, everything's fine. :)

@nl-danish
Copy link

nl-danish commented Jul 16, 2024

I'm a little confused,

Are we supposed to upgrade this packaged to the latest 4.3.3? Or, are we supposed to use this fix
Because in the latest commit, it seems that the package have removed the play core dependency and are not moving forward with it (reference)

Can anybody please guide? Thank you so much.

@MinaSamir11
Copy link
Owner

I'm a little confused,

Are we supposed to upgrade this packaged to the latest 4.3.3? Or, are we supposed to use this fix

Because in the latest commit, it seems that the package have removed the play core dependency and are not moving forward with it (reference)

Can anybody please guide? Thank you so much.

Did you follow the captain instructions or the passenger in the plane 😄
do not be confused this commit means nothing, it isn't affect on any thing in the package.

use the latest version.

Have a nice day.

@nl-danish
Copy link

@MinaSamir11
haha, good example.

thank you, have a nice day to you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants