Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: When sending 'max' amount ETH value is not adjusted in response to changes in the gas fee. #8516

Closed
sleepytanya opened this issue Feb 2, 2024 · 5 comments · Fixed by #12754
Closed

[Bug]: When sending 'max' amount ETH value is not adjusted in response to changes in the gas fee. #8516

sleepytanya opened this issue Feb 2, 2024 · 5 comments · Fixed by #12754
Assignees
@OGPoyraz
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

When sending 'max' amount ETH value on the confirmation screen is not recalculated when gas fee changes.

Expected behavior

ETH value should be adjusted in response to fluctuations in gas fees.

Screenshots/Recordings

gas.mov

https://recordit.co/i6mDDYRLYw

Steps to reproduce

  1. Send ETH to any address
  2. Choose 'max' amount
  3. Click 'Next' button
  4. Wait for the 'Estimated fee' to be updated automatically (or you can change it manually - 'Market' -> 'Aggressive' or 'Low'
  5. See the 'send' ETH amount on the confirmation screen is not adjusted

Error messages or log output

No response

Version

7.15.0, 7.16.0

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Device

Samsung Note20

Operating system

Android

Additional context

For the first video in the 'Screenshots/Recordings' section made on physical device Samsung Note20 5G, QA build, branch
Second video is the recording of 7.16.0.

Severity

No response
@sleepytanya sleepytanya added type-bug Something isn't working team-confirmations-system DEPRECATED: please use "team-confirmations" label instead Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Feb 2, 2024
@sleepytanya
Copy link
Contributor Author

v7.7.0 (Sep. 1, 2023) - same behavior, ETH value is not adjusted:

maxFee.mov

@vinistevam vinistevam self-assigned this Feb 15, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 19, 2024
@vinistevam vinistevam removed their assignment Feb 20, 2024
@sleepytanya sleepytanya changed the title [Bug]: When sending 'max' amount ETH value is not adjusted is response to changes in the gas fee. [Bug]: When sending 'max' amount ETH value is not adjusted in response to changes in the gas fee. Feb 27, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 9, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jul 30, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jul 30, 2024
@bschorchit bschorchit removed the stale Issues that have not had activity in the last 90 days label Aug 28, 2024
@bschorchit bschorchit reopened this Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 3, 2024
@bschorchit bschorchit reopened this Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Dec 4, 2024
@bschorchit bschorchit removed the stale Issues that have not had activity in the last 90 days label Dec 4, 2024
@OGPoyraz OGPoyraz self-assigned this Dec 17, 2024
@OGPoyraz OGPoyraz linked a pull request Dec 18, 2024 that will close this issue
feat: Implement send max to send flow #12754
Merged
7 tasks
@OGPoyraz OGPoyraz mentioned this issue Dec 18, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@OGPoyraz
feat: Implement send max to send flow (#12754)
2c5a2d0 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR implements "Use Max" feature to the send flow. 

In the `Amount` step we set `maxValueMode` as `true`. When user gets in
to the `Confirm` step, depending on the value, transaction value is
getting updated.

## **Related issues**

#8516 

## **Manual testing steps**

1. Try send eth - initiate from wallet
2. "Use max" value on the `Amount` screen
3. See that amount is adjusted on every gas update

## **Screenshots/Recordings**



https://github.com/user-attachments/assets/b785887e-1cb1-4937-9b3d-c15cc72057ea



### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jan 9, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGPoyraz OGPoyraz

Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Bugs by team
Status: Fixed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement send max to send flow MetaMask/metamask-mobile
6 participants
@OGPoyraz @cryptotavares @bschorchit @metamaskbot @vinistevam @sleepytanya