Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues with swaps e2e tests #11580

Closed
1 of 9 tasks
cortisiko opened this issue Oct 2, 2024 · 0 comments · Fixed by #11670
Closed
1 of 9 tasks

Address issues with swaps e2e tests #11580

cortisiko opened this issue Oct 2, 2024 · 0 comments · Fixed by #11670
Assignees
@davibroc
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps

Comments

@cortisiko
Copy link
Member

What is this about?

The Swaps end-to-end tests have been experiencing instability since last Thursday. The primary issue occurs after a transaction is submitted during the test flow. Instead of successfully proceeding to return the expected confirmation status, the transaction fails almost immediately. This failure consistently happens at the same point in the test sequence, suggesting a potential issue with the transaction handling or we need to refactor our tests. Further investigation is required in order to pinpoint the root cause and restore stability.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@cortisiko cortisiko added Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps labels Oct 2, 2024
@davibroc davibroc linked a pull request Oct 16, 2024 that will close this issue
test: Refactor e2e Swap test to use Tenderly Virtual TestNets #11670
Merged
7 tasks
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davibroc davibroc

Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Refactor e2e Swap test to use Tenderly Virtual TestNets MetaMask/metamask-mobile
3 participants
@davibroc @cortisiko @metamaskbot