Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Factory parameter setting #481

Open
arthurmloureiro opened this issue Jan 15, 2025 · 0 comments
Open

Inconsistency in Factory parameter setting #481

arthurmloureiro opened this issue Jan 15, 2025 · 0 comments
Labels

Comments

@arthurmloureiro
Copy link

Describe the bug
It seems like setting some parameters in the factory like alphag will actually fix those parameters inside firecrown instead of simply instantiating the factory objects with those values. This can will an issue for CosmoAPI as it will create a discrepancy between factory parameters for synthetic analysis.

For example, at the moment we can set the parameters for a synthetic analysis in CosmoAPI with

    systematics:
      type: WeakLensingFactory
      per_bin_systematics:
      - type: MultiplicativeShearBiasFactory
        mult_bias: [1e-3, 1e-3, 1e-3, 1e-3, 1e-3]
      - type: PhotoZShiftFactory
        delta_z: &delta_z [0.2, 0.1, 0.1, 0.2, 0.1]
      global_systematics:
      - type: LinearAlignmentSystematicFactory
        alphag: 1.0

This allows the user to set the parameters to generate a fake SACC data file.
However, if the user recycles this part of the code to then run a likelihood analysis, alphag will be fixed while the other parameters are not.

This is not really a bug just something that can cause some issues as different systematic factories seem to have different behaviour when constructing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant