Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be less strict for collectibles naming when searching #76

Open
thejacer87 opened this issue Jan 12, 2025 · 3 comments
Open

Be less strict for collectibles naming when searching #76

thejacer87 opened this issue Jan 12, 2025 · 3 comments

Comments

@thejacer87
Copy link
Contributor

Hi there,

Thanks for all the work so far on this plugin.

I'm trying to remake Metroid 1, and started using the plugin yesterday. One thing I thought was weird was that each collectible name had to match.

In my game, all the collectibles inherit from the collectibles class.

Would there be anyway to match parent class name instead of hard matching the node names?

Cheers

@KoBeWi
Copy link
Owner

KoBeWi commented Jan 12, 2025

It's possible, but it's more complex and would make scanning big maps much slower.
I could think about exposing some more advanced ways to match collectibles.
What's the problem with matching node names though? Usually each collectible is a separate scene and matching name allows to differentiate them and count different kinds of collectibles. If only the class was matched, they'd all fall under the same category, no?

@thejacer87
Copy link
Contributor Author

Related to randomizing like I mentioned in the other thread.

Thanks for the prompt responses 😃

@KoBeWi
Copy link
Owner

KoBeWi commented Jan 12, 2025

Collectible finder exists only for statistical purposes. It doesn't really have use for map randomization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants