Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MetSysModule game variable to _game? #70

Open
naturally-intelligent opened this issue Oct 31, 2024 · 1 comment
Open

Change MetSysModule game variable to _game? #70

naturally-intelligent opened this issue Oct 31, 2024 · 1 comment

Comments

@naturally-intelligent
Copy link

This is more of a request than an issue, but wanted to discuss feasibility here

Can we change MetSysModule.game to MetSysModule._game?

We have a global autoload called "game" that is conflicting with it. And when we make our own modules we want to use that global variable... so it's confusing! I've changed it in our own copy so it's not a deal-breaking issue. But going forward I do worry about upgrading and having to redo the changes.

Obviously I wouldnt request this just based on our situation, but maybe for best practice it should should be "_game" anyways even without our issue?

@KoBeWi
Copy link
Owner

KoBeWi commented Nov 2, 2024

I could call it _game if it was a "private" variable, but it's supposed to be used by modules, so current name is better.
Maybe you can rename the singleton instead? Using lowercase name for a singleton seems strange to me 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants