You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more of a request than an issue, but wanted to discuss feasibility here
Can we change MetSysModule.game to MetSysModule._game?
We have a global autoload called "game" that is conflicting with it. And when we make our own modules we want to use that global variable... so it's confusing! I've changed it in our own copy so it's not a deal-breaking issue. But going forward I do worry about upgrading and having to redo the changes.
Obviously I wouldnt request this just based on our situation, but maybe for best practice it should should be "_game" anyways even without our issue?
The text was updated successfully, but these errors were encountered:
I could call it _game if it was a "private" variable, but it's supposed to be used by modules, so current name is better.
Maybe you can rename the singleton instead? Using lowercase name for a singleton seems strange to me 🤔
This is more of a request than an issue, but wanted to discuss feasibility here
Can we change MetSysModule.game to MetSysModule._game?
We have a global autoload called "game" that is conflicting with it. And when we make our own modules we want to use that global variable... so it's confusing! I've changed it in our own copy so it's not a deal-breaking issue. But going forward I do worry about upgrading and having to redo the changes.
Obviously I wouldnt request this just based on our situation, but maybe for best practice it should should be "_game" anyways even without our issue?
The text was updated successfully, but these errors were encountered: