Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias for onTransitions #146

Open
tomaszmichalak opened this issue Mar 30, 2020 · 0 comments
Open

Alias for onTransitions #146

tomaszmichalak opened this issue Mar 30, 2020 · 0 comments
Assignees
@Voycawojka

Comments

@tomaszmichalak
Copy link
Member

Is your feature request related to a problem? Please describe.
There are many typing errors in the onTransitions configuration entry. We want to introduce an alias (on).

Describe the solution you'd like
Those configurations should mean the same:

action=fetch-user-info
on._success { }

and

action=fetch-user-info
onTransitions._success { }

Additional context
See the io.knotx.fragments.task.factory.GraphNodeOptions class.
@Voycawojka Voycawojka self-assigned this Mar 30, 2020
Voycawojka added a commit that referenced this issue Apr 7, 2020
@Voycawojka
#146 Implement transitions alias
d1e5df6
@Voycawojka Voycawojka mentioned this issue Apr 7, 2020
Merged
6 tasks
Voycawojka pushed a commit that referenced this issue Jul 14, 2020
#146 Adjust tests for transitions atlas
9f36471
Voycawojka added a commit that referenced this issue Jul 14, 2020
@Voycawojka
#146 Adjust tests for ontransitions
9a4a4e9
Voycawojka pushed a commit that referenced this issue Jul 15, 2020
Revert " #146 Adjust tests for ontransitions"
8cb207a 
This reverts commit 9a4a4e9
Voycawojka pushed a commit that referenced this issue Jul 15, 2020
#146 Fix line endings
e083431
Voycawojka pushed a commit that referenced this issue Jul 15, 2020
#146 Fix line endings
536ff39
tomaszmichalak pushed a commit that referenced this issue Aug 31, 2021
@Voycawojka
#146 Implement transitions alias (#150)
64ed7bd 
* #146 Implement transitions alias

* remove unnecesarry handlers

* #146 Adjust tests for transitions atlas

* #146 Adjust tests for ontransitions

* Revert " #146 Adjust tests for ontransitions"

This reverts commit 9a4a4e9

* #146 Fix line endings

* #146 Fix line endings

Co-authored-by: filip.kowalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Voycawojka Voycawojka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomaszmichalak @Voycawojka