Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run pipeline from workdir (with -s param) and not only from src dir #2

Open
olegs opened this issue Oct 19, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@olegs
Copy link
Contributor

olegs commented Oct 19, 2019

No description provided.

@olegs olegs added the bug Something isn't working label Oct 19, 2019
@iromeo
Copy link
Contributor

iromeo commented Oct 19, 2019

Yes, it is indented behaviour. We could make it more complicated to support launching from 'non pipeline src' folder, but is it really needed? Normally I use '-s' only for a playground when I'd like to patch it a bit. Or if pipeline folder contain several pipelines.

@iromeo iromeo removed the bug Something isn't working label Oct 19, 2019
@olegs
Copy link
Contributor Author

olegs commented Oct 19, 2019

That's how I use it generally. From the data folder.

@iromeo
Copy link
Contributor

iromeo commented Oct 19, 2019

IMHO such usecase breaks snakemake naming conventions, but I'll check it again (not 100% sure). Normally I do vice versa: launch from src folder and use workdir as an argument.

P.S: To be honest additional tweaks are required if your pipeline dir isn't same as workdir because we are supposed to use relative names but on runtime in some cases they are relative to current snakemake file and in other cases relative to working directory

@olegs
Copy link
Contributor Author

olegs commented Oct 19, 2019

I'd say that since Snakemake allows this execution pattern pipeline should follow it.

@iromeo
Copy link
Contributor

iromeo commented Oct 19, 2019

As I said before IMHO pipeline structure recommended by snakemake will not work with such pattern, but I'll check it

@iromeo iromeo changed the title Pipeline fails when used from external folder with -s param Allow to run pipeline from workdir (with -s param) and not only from src dir Oct 21, 2019
@iromeo iromeo added the enhancement New feature or request label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants