Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating new batch, provide default org #3

Open
JoeMurray opened this issue Sep 19, 2018 · 4 comments
Open

When creating new batch, provide default org #3

JoeMurray opened this issue Sep 19, 2018 · 4 comments
Assignees

Comments

@JoeMurray
Copy link
Member

If a batch is created without filling in options, Company is left as 'Any'. When trying to add Contribution to batch, this causes an error as owner of financial account for payment method doesn't match that of null value for batch.

  1. Create default for Company as contact_id of first enabled financial account.
  2. Change validation when adding a contribution to a batch on all backend forms so that there is no error on payment method not matching organization of batch if the latter is any.
  3. Change label and name of field from Company to Organization.
@JoeMurray JoeMurray assigned JoeMurray and Edzelopez and unassigned JoeMurray Sep 19, 2018
@JoeMurray
Copy link
Member Author

@JoeMurray
Copy link
Member Author

@JoeMurray
Copy link
Member Author

Completed 3 at 65d3fe1

@JoeMurray
Copy link
Member Author

Actually, 3 required additional changes at ee2c6bf and 83c223d but these involved renaming Company to Organization for label, variable and html. The variable change (likely) cause the contents of the Company column to be displayed as undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants