Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API endpoints configurable #43

Closed
tdemin opened this issue Jul 9, 2021 · 4 comments
Closed

Make API endpoints configurable #43

tdemin opened this issue Jul 9, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@tdemin
Copy link

tdemin commented Jul 9, 2021

For now this project won't play well with custom scrobble servers, such as Maloja, that support ListenBrainz API.

Unfortunately, listenbrainz_rust got the API URI hardcoded.

@InputUsername
Copy link
Owner

Thank you for this suggestion, I fully agree this would be a good feature to add.

I'm thinking of creating a ListenBrainz library (listenbrainz_rust is unmaintained and its repo is gone) with support for a configurable URL, and use that. Should hopefully not take too long.

@InputUsername InputUsername added the enhancement New feature or request label Jul 9, 2021
@shymega
Copy link

shymega commented Jul 23, 2021

@InputUsername Regards to Listenbrainz, I've been thinking of adding support for Listenbrainz to rustfm-scrobble - #41 (comment) - originally, I had planned to write a Listenbrainz library specifically for my scrobbler, but perhaps it might be a good idea to work together and add Listenbrainz support to rustfm-scrobble, as well as Libre.fm? I'm about to open an issue on that crate with the aforementioned proposal

@shymega
Copy link

shymega commented Jul 23, 2021

@InputUsername InputUsername added this to the v0.5.0 milestone Sep 29, 2021
@InputUsername
Copy link
Owner

This has been implemented in v0.5.0!

@tdemin I'm closing this issue for now, feel free to reopen if the current solution doesn't work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants