From 5df5418d72dbd07a75741dc8531fb20d5799a532 Mon Sep 17 00:00:00 2001
From: Timothy-Gonzalez <105177619+Timothy-Gonzalez@users.noreply.github.com>
Date: Sun, 12 Jan 2025 13:34:08 -0600
Subject: [PATCH] Remove isProApplicant from registration schemas

---
 src/services/admission/admission-router.test.ts       | 1 -
 src/services/profile/profile-router.test.ts           | 1 -
 src/services/registration/registration-router.test.ts | 1 -
 src/services/registration/registration-schemas.ts     | 5 -----
 src/services/staff/staff-router.test.ts               | 1 -
 5 files changed, 9 deletions(-)

diff --git a/src/services/admission/admission-router.test.ts b/src/services/admission/admission-router.test.ts
index 6cee298e..49eb5198 100644
--- a/src/services/admission/admission-router.test.ts
+++ b/src/services/admission/admission-router.test.ts
@@ -28,7 +28,6 @@ const OTHER_DECISION = {
 } satisfies AdmissionDecision;
 
 const TESTER_APPLICATION = {
-    isProApplicant: false,
     userId: TESTER.id,
     preferredName: TESTER.name,
     legalName: TESTER.name,
diff --git a/src/services/profile/profile-router.test.ts b/src/services/profile/profile-router.test.ts
index b4fbd6e7..11836ad1 100644
--- a/src/services/profile/profile-router.test.ts
+++ b/src/services/profile/profile-router.test.ts
@@ -55,7 +55,6 @@ const PROFILE = {
 const REGISTRATION = {
     userId: TESTER.id,
     hasSubmitted: true,
-    isProApplicant: false,
     preferredName: TESTER.name,
     legalName: TESTER.name,
     emailAddress: TESTER.email,
diff --git a/src/services/registration/registration-router.test.ts b/src/services/registration/registration-router.test.ts
index c32da0bf..1e6c2a6e 100644
--- a/src/services/registration/registration-router.test.ts
+++ b/src/services/registration/registration-router.test.ts
@@ -17,7 +17,6 @@ import type { AxiosResponse } from "axios";
 import { MailInfo } from "../mail/mail-schemas";
 
 const APPLICATION = {
-    isProApplicant: false,
     preferredName: TESTER.name,
     legalName: TESTER.name,
     emailAddress: TESTER.email,
diff --git a/src/services/registration/registration-schemas.ts b/src/services/registration/registration-schemas.ts
index a7b31a38..82cae2f5 100644
--- a/src/services/registration/registration-schemas.ts
+++ b/src/services/registration/registration-schemas.ts
@@ -75,9 +75,6 @@ export class RegistrationApplication {
     @prop({ default: false })
     public hasSubmitted: boolean;
 
-    @prop({ required: true })
-    public isProApplicant: boolean;
-
     @prop({ required: true })
     public preferredName: string;
 
@@ -187,7 +184,6 @@ export const RegistrationStatusSchema = z
 
 export const RegistrationApplicationRequestSchema = z
     .object({
-        isProApplicant: z.boolean(),
         preferredName: z.string(),
         legalName: z.string(),
         // Email address needs to allow empty string as placeholder value. Ideally we change this in the future, but this is a temp fix.
@@ -226,7 +222,6 @@ export const RegistrationApplicationRequestSchema = z
             degree: Degree.ASSOCIATES,
             major: "Computer Science",
             gradYear: 0,
-            isProApplicant: true,
             proEssay: "I wanna be a Knight",
             considerForGeneral: true,
             requestedTravelReimbursement: false,
diff --git a/src/services/staff/staff-router.test.ts b/src/services/staff/staff-router.test.ts
index b56845b7..f109601c 100644
--- a/src/services/staff/staff-router.test.ts
+++ b/src/services/staff/staff-router.test.ts
@@ -31,7 +31,6 @@ const TESTER_REGISTRATION = {
     hackOutreach: [HackOutreach.INSTAGRAM],
     dietaryRestrictions: ["Vegan", "No Pork"],
     resumeFileName: "GitHub cheatsheet.pdf",
-    isProApplicant: false,
     legalName: "Ronakin Kanandani",
     considerForGeneral: false,
     requestedTravelReimbursement: true,