Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Fix for Ring Calculation in RS128-Channel Point Clouds #17

Open
runjtu opened this issue Sep 9, 2024 · 0 comments
Open

Possible Fix for Ring Calculation in RS128-Channel Point Clouds #17

runjtu opened this issue Sep 9, 2024 · 0 comments

Comments

@runjtu
Copy link

runjtu commented Sep 9, 2024

Hi, Author

I recently encountered a potential issue in the code when handling 128-channel point clouds. Specifically, in the following code snippet:

else if (pc->height == 128) {
    new_point.ring = RING_ID_MAP_RUBY[point_id % pc->height];
}

From my testing, this calculation causes the ring value to always be set to 0 when converting from RS to Velodyne. I believe the following modification might work better:

else if (pc->height == 128) {
    new_point.ring = RING_ID_MAP_RUBY[point_id / pc->width];
}

This change resolved the issue on my dataset. However, since I've only tested it in my specific scenario, I'm suggesting it as a possible fix or an alternative approach. I hope this might be helpful! Thank you for your consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant