Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a project has givbacksEligible=true, verified=false then givpower behaves strange #4900

Open
divine-comedian opened this issue Dec 13, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@divine-comedian
Copy link
Contributor

Checking out a project on the app https://giveth.io/project/nextmeta this project is marked as givbacks eligible and can be boosted with givpower.

however when you look on the project info there is no tab to see it's givpower history aind information. Additionally after you have boosted the project with GIVpower you go to "My GIVpower" you receive a warning for the entry of the boost you just made to the project 👇
Image

looking further into the status of the project in the admin, it appears to be marked as verified=false and givbacks eligible = true

in the graphQL data for the project it returns no powerRank or totalPower, even though it's instant boosting rank was 14. Meaning that the GIVbacks calculations may have been consider the projects rank as 0, meaning donors would not be getting as much of the rewards from GIVbacks that they should have been.

Screencast.from.2024-12-13.07-48-31.webm

this can be resolved in the admin panel by selecting to "vouch" for the project, which turns verified=true, the project then has it's givpower tab shown and the warning in "my givpower" dissapears.

The issue

  • If a project is givbacks eligible then we should show the givpower tab and the givpower data correctly on the project page

  • the info around powerRank, etc.. should show correctly in the project data

  • there should be no warning in my givpower saying the project I boosted is not givbacks eligible when it is in fact

To remedy this you could:

  • change the way givpower rank (not instant boost) works to make sure it looks at the givbacksEligible project variable correctly
  • ensure when givbacksEligible is true, verified is always true in project data

Maybe there is other options that I am not aware of, only my suggestions here

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Dec 13, 2024
@divine-comedian divine-comedian added the bug Something isn't working label Dec 13, 2024
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Dec 13, 2024
@divine-comedian divine-comedian changed the title when givbacksEligible=true, verified=false project givpower behaves strange when a project has givbacksEligible=true, verified=false then givpower behaves strange Dec 13, 2024
@divine-comedian
Copy link
Contributor Author

@MohammadPCh informs me that Giveth/impact-graph#1866 should solve this issue.

@CarlosQ96 when you have time could you please giv this PR a review?

@divine-comedian divine-comedian moved this from Dev Research to QA in All-Devs Dec 23, 2024
@laurenluz
Copy link
Member

@divine-comedian it looks like the PR was merged - is this issue resolved? or it needs testing?

@divine-comedian
Copy link
Contributor Author

@laurenluz hey! I've been following this issue

it looks related to -> Giveth/impact-graph#1848 (comment) which was merged a while ago to production. Currently being QA'd

@laurenluz
Copy link
Member

ok thanks Mitch!

@divine-comedian divine-comedian moved this from Merged to Production to QA in All-Devs Jan 9, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Jan 13, 2025

however when you look on the project info there is no tab to see it's givpower history aind information. Additionally after you have boosted the project with GIVpower you go to "My GIVpower" you receive a warning for the entry of the boost you just made to the project 👇
Image

I've tested on production and it seems this problem has been fixed

Image

@maryjaf maryjaf moved this from QA to Done in All-Devs Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants