You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ManagedProcess class currently only relies on __del__ to clean up its underlying process, which can be unpredictable. Having such code as a failsafe may be reasonable, but we should add more explicit methods for cleaning things up in a predictable manner.
Summary of initial suggestion from a quick peruse from Kevin:
For subclasses of ManagedProcess shutdown might need to be subclass-specific.
Perhaps add @abstractmethod to ServerProcess for the shutdown and go from there,
being aware Python's weak add-on typing won't lead you to all the places that might
need to call that method.
N.B., this has the potential to affect the non-HTTP based connections. The HTTP connections rely almost entirely on the requests.post method for all comms handling.
The
ManagedProcess
class currently only relies on__del__
to clean up its underlying process, which can be unpredictable. Having such code as a failsafe may be reasonable, but we should add more explicit methods for cleaning things up in a predictable manner.Thanks @kquick for pointing out.
The text was updated successfully, but these errors were encountered: