Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow localization #90

Open
yarons opened this issue Sep 1, 2020 · 20 comments
Open

Allow localization #90

yarons opened this issue Sep 1, 2020 · 20 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yarons
Copy link
Contributor

yarons commented Sep 1, 2020

Please add some i18n framework to allow localization of the product.

Thank you!

@Forceu Forceu added enhancement New feature or request help wanted Extra attention is needed labels Sep 2, 2020
@PiAir
Copy link
Contributor

PiAir commented Feb 7, 2022

I noticed a pull request #119 was created for this issue that hasn't made it into a release yet. What kind of help is still wanted there?

@yarons
Copy link
Contributor Author

yarons commented Feb 7, 2022

It looks great, now we can either leave it like that or connect it to a localization platform to ease the translation:
Weblate and TranslateWiki are open source, Weblate offers commercial support while TranslateWiki doesn't.
Transifex and Crowdin, both closed source with free open source hosting.

I think it's better to wait until @olekenneth will finish his localization prep and we can add it when all the files are ready for localization and the PO file is as wide-spread as possible.

@PiAir
Copy link
Contributor

PiAir commented Feb 7, 2022

I think it's better to wait until @olekenneth will finish his localization prep and we can add it when all the files are ready for localization and the PO file is as wide-spread as possible.

Sure (and it was not that I was looking for work, just was interested in having a localized version so I can send the log messages to my Home Mini). I was asking because the last update of that pull request was from almost a year ago and I wasn't sure if it was still being worked on.

@olekenneth
Copy link
Contributor

I think I got it working. I'll try to find the code and commit it

@yarons
Copy link
Contributor Author

yarons commented Feb 7, 2022

Cool, do you need my assistance with Weblate migration or any other platform? @comradekingu

@olekenneth
Copy link
Contributor

@yarons
Copy link
Contributor Author

yarons commented Feb 7, 2022

It's inaccessible for me, can you make this project public so I can join?

@olekenneth
Copy link
Contributor

I'm not sure if that's possible? I can invite a username or email to my team. Maybe switch to better platform?

@yarons
Copy link
Contributor Author

yarons commented Feb 7, 2022

Weblate is fully open source and allows 30 days before confirming your open source license.
Transifex organizations can be published, this is my organization:
https://www.transifex.com/yaron/

@comradekingu
Copy link
Contributor

Happy to help if you use Weblate. Either set up shop on https://weblate.bubu1.eu/ or https://hosted.weblate.org/hosting/
and add "kingu".
Transifex is the worst of all possible options.

@olekenneth
Copy link
Contributor

Maybe @Forceu will create that? Doesn't make sense for me to control it.

@Forceu
Copy link
Owner

Forceu commented Feb 7, 2022

Sorry guys that I haven't looked into this much any sooner. Unfortunately I do not have a lot of spare time for this project at the moment. I created a hosted version with Weblate which can be accessed at https://hosted.weblate.org/projects/barcode-buddy/

I added @comradekingu as an administrator, let me know your usernames so I can add you as well

@yarons
Copy link
Contributor Author

yarons commented Feb 7, 2022

Cool, mine is @yaron.

There are no components yet, we may need your help adding the appropriate git permissions.

@Forceu
Copy link
Owner

Forceu commented Feb 7, 2022

Thanks I added you as well. I am not sure how exactly to add the components, I assume I entered something incorrectly; do you know how to add a component (or can you do it from the weblate interface)?

image

@PiAir
Copy link
Contributor

PiAir commented Feb 7, 2022

I created an account @PiAir at weblate also, but maybe it's best to leave me as non-administrator so you have someone to test it from that end as soon as you've set it up?

Vertaalstatus

@comradekingu
Copy link
Contributor

comradekingu commented Feb 7, 2022

Up and running now on https://hosted.weblate.org/projects/barcode-buddy/
Are there any other strings/resources to add?
Where are the Android strings?

nb_NO translation without a firm understanding of what "consume" constitutes also made.
Should arrive as a PR.

@Forceu If you can add a webhook, as per
https://docs.weblate.org/no/latest/admin/continuous.html#github-setup
and merge #185 (merged)
I think that will do.

Possibly the https://github.com/weblate user needs to be added to the org.
Sometimes GitHub complains about that, but I don't know why and when.

@PiAir
Copy link
Contributor

PiAir commented Feb 7, 2022

Dutch also done.

Vertaalstatus

@Forceu
Copy link
Owner

Forceu commented Feb 7, 2022

Awesome, thanks a lot guys! I will do the German translation tomorrow and then have a look on how to integrate it into Barcode Buddy.

@yarons
Copy link
Contributor Author

yarons commented Feb 8, 2022

That's awesome, I would also like to help with RTL, is there a way to add "dir=rtl" to the HTML/body tag when Hebrew is selected? this way I can make those changes without modifying the LTR (English) CSS stylesheet.

@Forceu
Copy link
Owner

Forceu commented May 6, 2022

First of all thanks to everyone who helped translating! In the last months I haven't had enough time to incorporate the translations, but I have not forgotten about it. As soon as I have enough time (or someone creates a PR), this will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants