Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Adding Sf vardumper caster for Stripe #31

Open
Nek- opened this issue Mar 27, 2023 · 3 comments
Open

[RFC] Adding Sf vardumper caster for Stripe #31

Nek- opened this issue Mar 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Nek-
Copy link

Nek- commented Mar 27, 2023

Hello,

I just saw this article from JoliCode, and I immediately though that it would be a nice feature to add to this bundle. WDYT?

https://jolicode.com/blog/leverage-symfony-vardumper-component-to-enhance-your-dumps

@Prometee Prometee transferred this issue from FLUX-SE/SyliusPayumStripePlugin Mar 27, 2023
@Prometee
Copy link
Member

Hello @Nek-

Thank you for sharing this ! I read it this morning too and think about adding it to the Payum Stripe lib (that's why I moved your issue here 😉).

@Prometee Prometee added the enhancement New feature or request label Mar 27, 2023
@Nek-
Copy link
Author

Nek- commented Mar 27, 2023

To me, it's more a bundle thing (since it's tight to Symfony) but fine.

@Prometee
Copy link
Member

I used the var dumper inside a raw project with dependencies with only this Payum Stripe lib.
Adding the caster class here will just add a tool to the lib that can be used in a Symfony project or more widely in any type of project that can use the var dumper.
Then the bundle will configure it if needed.
Here are the steps I propose to follow to add this caster :

  • Add the caster class
  • Add a suggested package : symfony/var-dumper
  • In the bundle source : add a standalone config file to be able to configure the var dumper or found a way to detect the var dumper presence and autoconfigure it via a compiler pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants