Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow fitting (also, clean up timing information) #14

Open
bcdaniels opened this issue Jan 18, 2019 · 0 comments
Open

Slow fitting (also, clean up timing information) #14

bcdaniels opened this issue Jan 18, 2019 · 0 comments

Comments

@bcdaniels
Copy link
Contributor

Fitting of the example data in simpleExample.py is now slower, taking ~10 hours on my laptop instead of "a few" hours claimed in the original. Comparing minimization times stored in minimizationTimeSecondsList, they are indeed roughly 5x longer. We may need to check that integration is actually being done using compiled C code or whether there is a fallback to python code.

Diagnostic timing information is saved when running fitting (in minimizationTimeSecondsList and ensTimeSecondsList) but we may want to revisit this and make it more interpretable—e.g. the typical time it takes to integrate the equations once. Also, the ensemble time appears to be incorrect when running in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant