Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set boundary conditions? Only from the source code? #213

Closed
MostafaGomaa93 opened this issue Dec 19, 2023 · 3 comments
Closed

How to set boundary conditions? Only from the source code? #213

MostafaGomaa93 opened this issue Dec 19, 2023 · 3 comments
Labels
modflow coupling This issue or pull request already exists

Comments

@MostafaGomaa93
Copy link
Contributor

MostafaGomaa93 commented Dec 19, 2023

Hi @SarahAlidoost, @BSchilperoort and @yijianzeng

Is the only way to set the boundary conditions (e.g. NBChB = 1 or 2 or 3) through changing the value inside the source code? or that could be done from outside (e.g. from a text file).

If I talk about STEMMUS_SCOPE_MODFLOW -> NBChB must be 1 always ( I see that default value is 3 in this line).

Also, if there is groundwater temperature data available -> NBCTB will be also = 1

@SarahAlidoost
Copy link
Member

Is the only way to set the boundary conditions (e.g. NBChB = 1 or 2 or 3) through changing the value inside the source code? or that could be done from outside (e.g. from a text file).

Currently no. The variable NBChB is set only in one script setBoundaryCondition.m. If it is defined in a file such as the config file, it can be set from outside. In your case, if NBChB is always 1, then it can be set internally. There is also a file getModelSettings.m. that contains some settings. It would be nice if eventually the content of this file is moved to the config file. But please note that some of those settings have not been tested, see #196

@MostafaGomaa93
Copy link
Contributor Author

MostafaGomaa93 commented Dec 20, 2023

I would agree with @SarahAlidoost to move some of the content of both the setBoundaryCondtion.m and getModelSettings.m to the config file. It will be easier for the users later to change the settings based on their applications. That will also be helpful to generate a new exe with changing these settings from the config file and be latter used with the BMI (without the need to generate a new exe for each time we want to change the model settings). what do you think @yijianzeng?

@Lianyu-Yu
Copy link

For STEMMUS-MODFLOW, all the STEMMUS settings are in the file STEMMUS_config.m, which is the combination of the original files 'Constants.m' and 'StartInit.m'.

@SarahAlidoost SarahAlidoost added the modflow coupling This issue or pull request already exists label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modflow coupling This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants