-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SEO: First 5 Fundamental Lessons #214
Comments
NIce one Okhai for opening this 😄 |
Thanks for sharing @elPiablo comment. About to work on this task for a bit right now. |
@elPiablo I updated the titles to a similar format as example shown below. P.S. Code branch was derived off After<LessonHeader
title="Fundamentals: Getting Started with the Command Line Interface"
/> I didn't add the optional discussion link props as there is none for this fundamental courses. Do you want me to create one? BeforeAlso, below is an example of the LessonHeader component, and it accepts only two props. Do you want me to modify this so it can accommodate a similar input as what you suggested in your comment #205 (comment)? export function LessonHeader({ title, discussionUrl }: LessonHeaderProps) {
let forumLink = discussionUrl || DEFAULT_DISCUSSION_URL
return (
<Box>
<Box>
<Text
mt="1.5em"
fontWeight="bold"
fontSize="1.875rem"
letterSpacing={-0.025}
color="yellow.300"
>
{title}
</Text>
</Box>
{forumLink && (
<HStack marginY={6} columnGap={2} maxWidth="xl">
<Box>
<QuestionIcon w={8} h={8} />
</Box>
<Box>
If you get stuck or have questions please visit our{' '}
<Link
as={NextLink}
href={forumLink}
passHref
isExternal
textDecoration="underline"
>
forum
</Link>
.
</Box>
</HStack>
)}
</Box>
)
} I am still looking at some extra steps I can work on to improve the page SEO, just thought to leave an update. |
Hey @okhaimie-dev :) |
Would it be an idea @okhaimie-dev to just create a separate branch for the work on these issues? Branch for quiz-lesson-4 was getting quite a lot of changes to the .mdx and new files being created to house the quizzes and questions. And Marc and Brian were reviewing those each time I do changes. It might get messy if there is other work going on on that branch elsewhere too. |
Good question, Tony. John mentioned this a while ago, I think. Do we really want to have to maintain/moderate these fundamentals' content pieces on Peeranha? Or should we only add links for fundamentals that are a tutorial? Would you mind putting this question on the agenda for Thursday's weekly sync? I'll pop a link into the #academy channel somewhere and tag you. In the meantime, is it possible just to put that placeholder code in for now, or is that bad practice?
I think it's correct that it only has those two props ( |
I created a new branch I am 100% sure there will be no merge conflicts this way |
Alright. I will take out the "Fundamentals" prefix |
We have two parallel SEO-related conversations happening here and here 👉🏻 #205 - SEO is a holistic challenge, and the approach must be consistent across the site to work well. How does everyone feel about opening a new issue related to SEO generally on Academy? The goals as I see them would be to:
These are relatively low lift things they just need to be considered as a whole, not in isolation per course/track I have a quite a lof of experience in SEO and would be happy to drive this work - already scheduled time on Tuesday morning to spend two hours going through the site and making suggestions on how things can be improved (a lot of which has been discussed in the other thread) |
Seeing as you have spent more time working on this project, I believe you are better suited to drive the S.E.O. work. If you don't mind starting the new issue, then we can close the other two issue on for the S.E.O. I'll still love to learn the best strategies on S.E.O. from you, so I will watch how your approach it this time, and will be happy to assist when the need arises. cc: @elPiablo |
Looking good to go @okhaimie-dev and @kempsterrrr Sounds good to open a fresh issue with this folks. Do we delete the present issues? Or do these present ideas get integrated to the new one? Do these proposals influence your work flow @uma-l? Just want to make sure you're up to speed with all this. (please tag Uma in new issue) And should we @wolovim and I not change any titles/text at this stage in the lesson reviews we're doing? (not a big deal right now, but nice to know). IN this new issue, could we maybe have some kind of rough timeline + implementation of changes + features. Something simple/visual to get our heads around? Cheers |
@elPiablo why don't we close this issue and instead continue the conversation in #205 ? I can lay out a timeline in there if you're happy with that, with the goal of creating a clear set of deliverables to update the SEO structure of the site. The main changes I imagine that might impact Uma are :
But let's have that conversation on the other issue if/when we get to that :) Optimistically closing this issue - re-open if you want :) |
sounds good to me that you closed this @kempsterrrr :) |
We need to homogonise lesson titles and descriptions (including in the lesson body .mdx texts)
The titles in the front matter in the .mdx files don't match the titles in the 'Tracks' or 'Get Started' landing pages. It would be nice to use the same titles in all places including in the lessons.
Also, we need to take into consideration of the descriptions of the lessons in 'Tracks' and also in the lessons themselves. Quite often in these two places, we refer to e.g. lesson 1, or lesson 4 when these 'numbers' aren't represented in the actual lesson titles.
The text was updated successfully, but these errors were encountered: