Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABS 1D BND not fully working #5

Open
CyprienBosserelle opened this issue Sep 19, 2018 · 5 comments · May be fixed by #51
Open

ABS 1D BND not fully working #5

CyprienBosserelle opened this issue Sep 19, 2018 · 5 comments · May be fixed by #51
Labels

Comments

@CyprienBosserelle
Copy link
Owner

Working only for water level that is stable?

Needs a full test suite to verify what does and doesn't work.

uumean is forced to 0.0 in the function thus imposing a forced no mean flux along the boundary which is completelly imcompatible with bnd with variable condition.

How is that going to work with horizontal discharge of RIver along the boundary?

@CyprienBosserelle
Copy link
Owner Author

This is properly working after bugfix (108642e)

uumean is tsill set to 0 so it probably won't properly work on high frequency waves forcing.

@CyprienBosserelle
Copy link
Owner Author

Indeed this has not really been resolved and more work needs to be done to store and reuse umean

@CyprienBosserelle
Copy link
Owner Author

Confirming there is a bug here in the latest version to do with wet/dry interface. This urgently needs attention.

@CyprienBosserelle
Copy link
Owner Author

The wet/dry instability has been tamed to some degrees and probably improved with the new bug fixes but more testing is required to confirm this is fully working.

@CyprienBosserelle
Copy link
Owner Author

uumean is still forced to 0.0. so that part is not working yet.

@CyprienBosserelle CyprienBosserelle linked a pull request Jan 25, 2023 that will close this issue
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant