Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantics: isPassed #12

Closed
kangarang opened this issue Oct 20, 2017 · 3 comments
Closed

Semantics: isPassed #12

kangarang opened this issue Oct 20, 2017 · 3 comments

Comments

@kangarang
Copy link
Contributor

isPassed can refer to a thing or a moment that has "come and gone". Like tears....in rain.

Some ideas as to how we can rename this function:

  • pollEndedWithMajorityVotesForOP
  • pollDoneWinnerIsOP
  • winnerIsOP
  • opWonKenobi

OP as in Original Publisher or Original ParamProposer or Original PostMalone.
@kangarang
Copy link
Contributor Author

kangarang commented Feb 2, 2018 •
edited
Loading

Furthermore, isPassed is inconsistent with getNumPassingTokens.

isPassed: returns true ONLY if the applicant won a challenge
getNumPassingTokens: returns the number of tokens of a VOTER who voted in the majority_bloc of a poll

will think of suggestions in the near-future

@kangarang
Copy link
Contributor Author

majority bloc

isPassed -> majorityBlocVotedFor

rewardPool -> majorityBlocRewardPct

getTotalNumberOfTokensForWinningOption -> getTotalMajorityBlocNumTokens

totalTokens -> totalMajorityBlocNumTokens

winning voter

getNumPassingTokens -> getWinningVoterNumTokens

@kangarang
Copy link
Contributor Author

closing. see #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kangarang