Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal functions imported using package namespace #61

Open
fnattino opened this issue Jan 16, 2025 · 1 comment
Open

Internal functions imported using package namespace #61

fnattino opened this issue Jan 16, 2025 · 1 comment

Comments

@fnattino
Copy link
Contributor

I think one should be able to call internal functions directly, i.e. without referencing the name of the package?

For example, the following:

river_surface <- CRiSp::osmdata_as_sf("natural", "water", bb)

Could be replaced with:

river_surface <- osmdata_as_sf("natural", "water", bb) 

Am I missing something here, @cforgaci ?

@cforgaci
Copy link
Contributor

I think one should be able to call internal functions directly, i.e. without referencing the name of the package?

For example, the following:

CRiSp/R/osmdata.R

Line 165 in 85ec2ac

river_surface <- CRiSp::osmdata_as_sf("natural", "water", bb)
Could be replaced with:

river_surface <- osmdata_as_sf("natural", "water", bb)
Am I missing something here, @cforgaci ?

You are right. That looks like a leftover namespace, does not have to be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants