Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing Voice vlan in sdwan_switchport_feature_template #149

Closed
rrahimm opened this issue Jan 18, 2024 · 7 comments
Closed

missing Voice vlan in sdwan_switchport_feature_template #149

rrahimm opened this issue Jan 18, 2024 · 7 comments
Assignees
Labels
question Further information is requested

Comments

@rrahimm
Copy link

rrahimm commented Jan 18, 2024

we see that the Voice Vlan option is missing

we also see that an option called "dot1x_voice_vlan" exists, but doesn't exist in vManage. Possibly a typo error.

@danischm
Copy link
Member

What specifically is the request here? Voice vlan ID can be configured per interface.

@danischm danischm added the question Further information is requested label Jan 26, 2024
@rrahimm
Copy link
Author

rrahimm commented Jan 29, 2024

i only see dot1x_voice_vlan

is it a typo error in provider ?

image

@danischm
Copy link
Member

You mean why it is called dot1x_voice_vlan instead of voice_vlan? It is derived from the vManage schema:

                {
                    "dataPath": [
                        "dot1x"
                    ], 
                    "dataType": {
                        "max": 4094, 
                        "min": 1, 
                        "type": "number"
                    }, 
                    "defaultOption": "ignore", 
                    "description": "Voice VLAN ID", 
                    "details": "Configure Voice Vlan", 
                    "key": "voice-vlan", 
                    "objectType": "object", 
                    "optionType": [
                        "constant", 
                        "variable", 
                        "ignore"
                    ]
                },

If this is not correct we can adjust the name in the Terraform resource.

@rrahimm
Copy link
Author

rrahimm commented Jan 29, 2024

Hi @danischm

yes, that was the concern. I did some analysis and found that there is no Voice_vlan option under dot_1x, so calling it as dot1x_voice_vlan may not be right !!!

but, to my surprise, that's how the API also calls it in the payload.

It's a simple update to the Terraform Module that I can make and let this work.

or do you think, this should be renamed accordingly in Provider?

@danischm danischm self-assigned this Mar 1, 2024
@danischm
Copy link
Member

danischm commented Mar 2, 2024

Renamed: 297bf00

@danischm
Copy link
Member

Renamed in v0.3.6.

@rrahimm
Copy link
Author

rrahimm commented Mar 18, 2024

PR Created >> netascode/terraform-sdwan-nac-sdwan#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants