Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Filter without additional params, just next config file #104

Open
whawker opened this issue May 8, 2024 · 1 comment
Open

Comments

@whawker
Copy link

whawker commented May 8, 2024

Describe Request:

Currently mapping requires you to pass 3 or 4 values on each line

# currently the supported format for each of the mapping parameter is either:
# path-regex pipeline-parameter pipeline-parameter-value
# OR
# path-regex pipeline-parameter pipeline-parameter-value config-file
if not (element_count == 3 or element_count == 4):
raise Exception("Invalid mapping length of {}".format(element_count))

I don't believe a parameter is always necessary, sometimes you just want to forward to a continuation path, without additional parameters.

That is to say, could support for 2 values only be added? (i.e. no params), I believe this would be a common use case in mono repos.

Examples:

    jobs:
      - path-filtering/filter:
          base-revision: main
          mapping: |
            my-app/.* my-app/.circleci/config.yml
            my-other-app/.* my-other-app/.circleci/config.yml

Supporting Documentation Links:

https://circleci.com/developer/orbs/orb/circleci/path-filtering?version=1.0.0

@pc-bob
Copy link

pc-bob commented Jul 15, 2024

would be great, right now I have to add a dummy param to all my continuation configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants