Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSPKI module changes #9

Open
miclip opened this issue Jul 6, 2016 · 6 comments
Open

PSPKI module changes #9

miclip opened this issue Jul 6, 2016 · 6 comments

Comments

@miclip
Copy link

miclip commented Jul 6, 2016

It seems the latest PSPKI module has changed. New-SelfSignedCertificate is now New-SelfSignedCertificateEx

PSPKI Documentation for New-SelfSignedCertificateEx

@wangzq
Copy link

wangzq commented Aug 8, 2016

Is it a typo that the version should be 3.2.5 instead of 3.5.2?

@wangzq
Copy link

wangzq commented Aug 8, 2016

Also, current code seems only working with 3.2.5 exact version number, which may be a problem once the module is upgraded to a newer version such as 3.2.6:

if($PSPKIVersion.Major -ieq 3 -And $PspkiVersion.Minor -ieq 2 -And $PspkiVersion.Build -ieq 5) {

@ChackDan
Copy link
Owner

ChackDan commented Aug 8, 2016

@wangzq -Good suggestion.
@miclip - thankyou for letting me know. I will update the package with your suggestions.

@aviade
Copy link

aviade commented Sep 22, 2017

I fixed it and sent out a PR #31 @ChackDan - please review. Because of this bug the script is using New-SelfSignedCertificate instead of New-SelfSignedCertificateEx when using the latest (3.2.6) version of PSPKI.

The problem is that the New-SelfSignedCertificate code path creates a certificate that can't be used from SF cluster since the private key cannot be extracted

@aviade
Copy link

aviade commented Sep 27, 2017

Fix is now merged.

@antonGritsenko
Copy link

Just for better understanding. Will selfsigned certificate generation work if PSKI module is not installed (with this "install cert to My store | Export it" approach)? I have issue with certificate generated by the Invoke-AddCertToKeyVault and just want to be sure what I'm, doing everything in correct way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants