Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in /src/batch.js #7

Open
RyanChernoff opened this issue Jan 16, 2025 · 2 comments · May be fixed by #10
Open

Refactoring code in /src/batch.js #7

RyanChernoff opened this issue Jan 16, 2025 · 2 comments · May be fixed by #10
Assignees
@RyanChernoff

Comments

@RyanChernoff
Copy link

The function defined for exports.processSortedSet is too long including many conditionals and while loops. The cognitive complexity of the function is 40 when it really should be at 15. Abstraction of some of the components of the function appears necessary to increase readability.
@RyanChernoff
Copy link
Author

I would like to work on this please!

@github-actions GitHub Actions
Copy link

Great! I assigned you (@RyanChernoff) to the issue. Have fun working on it!

@RyanChernoff RyanChernoff linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanChernoff RyanChernoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored src/batch.js to increase readability RyanChernoff/NodeBB
1 participant
@RyanChernoff