Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid multiple theme checks #400

Open
1 task done
SGI-CAPP-AT2 opened this issue Dec 15, 2024 · 2 comments · May be fixed by #402
Open
1 task done

fix: Avoid multiple theme checks #400

SGI-CAPP-AT2 opened this issue Dec 15, 2024 · 2 comments · May be fixed by #402
Assignees
Labels
enhancement New feature or request

Comments

@SGI-CAPP-AT2
Copy link
Contributor

Describe your improvement idea or feature request

Currently Across application there are multiple theme checks being done for every widget build.
Like shown below:

backgroundColor: AppSettings.isDarkMode
? TaskWarriorColors.kprimaryBackgroundColor
: TaskWarriorColors.kLightPrimaryBackgroundColor,
surfaceTintColor: AppSettings.isDarkMode
? TaskWarriorColors.kprimaryBackgroundColor
: TaskWarriorColors.kLightPrimaryBackgroundColor,
child: Container(
color: AppSettings.isDarkMode
? TaskWarriorColors.kprimaryBackgroundColor
: TaskWarriorColors.kLightPrimaryBackgroundColor,

How would you like to see it implemented?

  1. Currently Global ThemeData are empty in utils/themes so populate them with existing values being used
  2. Refactor the code where checks are made if it's not causing any issue
  3. Change the theme with Get.changeTheme

Put here any screenshots or videos (optional)

No response

How can we contact you (optional)

@SGI-CAPP-AT2

Would you like to work on this issue?

Yes

By submitting this issue, I have confirmed that:

  • I have starred the repo ⭐ and watched 👀 it on GitHub and followed the contribution guidelines.
@SGI-CAPP-AT2 SGI-CAPP-AT2 added the enhancement New feature or request label Dec 15, 2024
@SGI-CAPP-AT2
Copy link
Contributor Author

@BrawlerXull please review this issue and assign me if it's appropriate to make changes

@BrawlerXull
Copy link
Collaborator

BrawlerXull commented Dec 15, 2024

Hey the issues are open to be solved by everyone it will be merged on first come first serve basis
First good pr will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
2 participants