Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist MyEtherWallet for file:// origin #7

Closed
SCBuergel opened this issue Apr 13, 2020 · 8 comments
Closed

Whitelist MyEtherWallet for file:// origin #7

SCBuergel opened this issue Apr 13, 2020 · 8 comments
Labels
wontfix This will not be worked on

Comments

@SCBuergel
Copy link

(I'm not sure if this is an issue for MyEtherWallet or this bridge)

When loading MyEtherWallet not via their website but instead from their static build locally (local HTML file) then I get the error Trying to connect from a non-whitelilsted origin. If possible, it would be very useful to interface a static, local and offline copy of MyEtherWallet to reduce attack vectors further.

@NickeZ
Copy link
Collaborator

NickeZ commented Apr 13, 2020

It is supposed to work if you use 127.0.0.1 or localhost. Are you using some other domain to refer to your localhost?

@SCBuergel
Copy link
Author

I just opened the index.html which is probably stupid and can't work due to permissions (?). The reason I was trying is that it's hard to host the web app by running a local web server on TailsOS. It's not only resilience and security by air-gapping but I want to do also do that because MyEtherWallet does not seem to load in the TOR browser.

@NickeZ
Copy link
Collaborator

NickeZ commented Apr 14, 2020 via email

@NickeZ
Copy link
Collaborator

NickeZ commented Apr 21, 2020

btw, if you have python you can run python3 -m http.server in the directory of the index.html file and get a quick http server up and running. This might be a valid workaround until I get time to look at the real issue.

@x1ddos
Copy link
Contributor

x1ddos commented Apr 26, 2020

If possible, it would be very useful to interface a static, local and offline copy of MyEtherWallet to reduce attack vectors further.

127.0.0.1 or ::1 is local and can be as much offline as you want it to be. It's a loopback and requires no internet connection.

From https://github.com/MyEtherWallet/MyEtherWallet#developers, the last step:

  1. App should be running in https://localhost:8080

Alternatively, use a static file server like what @NickeZ suggested in #7 (comment)

@x1ddos
Copy link
Contributor

x1ddos commented Apr 26, 2020

You'll want to bind to loopback only though. I would recommend something like:

python3 -m http.server --bind 127.0.0.1

@x1ddos
Copy link
Contributor

x1ddos commented Apr 26, 2020

More static file servers: https://gist.github.com/willurd/5720255

@x1ddos
Copy link
Contributor

x1ddos commented Apr 26, 2020

To summarize: opening an HTML file like MEW's index.html directly with a browser is no more secure than 127.0.0.1 while offline.

Though, I made a feature request out of this. See details in #9.

@x1ddos x1ddos closed this as completed Apr 26, 2020
@x1ddos x1ddos added the wontfix This will not be worked on label Apr 26, 2020
@x1ddos x1ddos changed the title whitelist MyEtherWallet from local source Whitelist MyEtherWallet for file:// origin Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants